Code Monkey home page Code Monkey logo

Comments (3)

joshburgess avatar joshburgess commented on May 30, 2024

Thanks. This is because of the init action I'm dispatching. I had an idea for it originally, but never ended up making use of it. So, I will probably just remove it altogether...... but will need to make this a breaking change just in case anyone was watching it in their apps as a signal to do something.

If you'd like to add this to your #29 PR, I will merge it together. If not, I can do it.

It's basically just deleting the EPIC_BEGIN constant from the constants file + the epicBegin action creator + removing the import & this middlewareApi.dispatch(epicBegin()) line in createEpicMiddleware.

from redux-most.

mbohgard avatar mbohgard commented on May 30, 2024

I can do it. What about the EPIC_END action. Should we get rid of that as well, since there's no EPIC_BEGIN anymore?

from redux-most.

joshburgess avatar joshburgess commented on May 30, 2024

No, I think that should stay. It's something I borrowed from redux-observable. That one has more of a purpose. It's to use as a trigger for initiating any sort of cleanup work you might want to do when using the replaceEpic method (hot reloading is the most common use case for this, but there are others.)

That one fires only later on. So, it's unrelated to the new code they added in Redux that's causing the error you're seeing. EPIC_BEGIN is fired during the construction phase though.

from redux-most.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.