Comments (13)
@xon52 @JosephusPaye I have submitted a PR with a vue 3 migration which works quite well and has almost no breaking changes.
from keen-ui.
Thanks to a lot of work by @kilobyte2007, the next
branch now has a working Vue 3 version of the library.
What we need now for publishing:
- Updating the CHANGELOG.md, README.md and perhaps CUSTOMIZATION.md with changes and updated usage information
- Testing usage of the built library code in an application. See this draft PR: #552.
Once #552 is done and merged we can publish a beta to npm for external testing, and then complete the documentation updates to publish a stable v2!
I've also added formatting and linting with prettier and eslint, as well as GitHub Actions CI.
from keen-ui.
Hello,
Thanks for your interest in Keen UI 2.0. I'd very much like to get the project going again, after the interruption this year.
Why Storybook
I've found Storybook to be a good way to develop and debug the components in isolation. It will not be replacing the docs, where the primary goal is to document the API and describe how to use the components. Though there's overlap, I think separating the two will be better for development in the long run. I will also also make it easier to use something like VuePress to write the documentation in Markdown. With Storybook we can also embed some of the stories in the documentation, to avoid duplicate work.
Upgrading to Vue 3
For the Vue 3 upgrade, I think the first place to start for the Vue 3 upgrade is choosing the overall strategy:
- Develop a backward-incompatible version for Vue 3 only: this could provide the opportunity to redesign the API of some of the components based on what we've learned using it for the past few years, and fix some of the long standing issues.
- Upgrade the current library to support Vue 3, keeping Vue 2 support: how feasible is this if we want to use some of the new features (like teleport and the composition API)? Will it require consumers of the library using Vue 2 to install additional compatibility libraries?
Doing some research to answer these questions and see what Vue recommends officially, and what other libraries are doing would be a good first step.
from keen-ui.
@kilobyte2007 Thanks a lot for the PR! I've left a review.
from keen-ui.
Thanks for #552 @kilobyte2007.
I've been doing some work on the next
branch to automate the process of publishing a new release to NPM and publishing updated docs to GitHub Pages.
Overall here's what's left now for us to publish v2:
- Finish automation of publishing updated docs (first part done in #554)
- Finish automation of publishing new releases
- Update CHANGELOG.md for all the changes from v1.4.0 (the current published version) and v2.0. I've started to do it here, but help wanted!
Feel free to help with any of the above!
from keen-ui.
Hey, has any work started on this? I would really want to upgrade our products to Vue 3 and Keen-UI is the latest library that keeps us from that. I would be ready to start migrating a few Keen-UI components but I would need to understand the direction and your vision on this.
from keen-ui.
I think the quickest approach at this point to add Vue 3 support would be to port the current library to Vue 3 with the same API where possible (if a Vue 3 change forces an API change, then we change), and release that as v2.
So those upgrading to Vue 3 can focus on Vue's breaking changes without further breaking changes from Keen UI.
After this, any fixes and improvements to the API that require breaking changes can come as part of another major version of Keen UI, perhaps v3.
As for how to help with this effort, I'd recommend starting with the Storybook branch (https://github.com/JosephusPaye/Keen-UI/tree/storybook/stories). Any of the following contributions would be a big help:
- Create a PR targeting that branch that upgrades Storybook to latest and Vue to v3
- Go though each component (perhaps one PR per component) and port its current examples in the
docs-src/
folder to Storybook stories, fixing any Vue 3 incompatibilities, and update the docs
At the end of that process we'd be in a position to update the docs site and release a Keen UI v2 with support for Vue 3.
from keen-ui.
@kilobyte2007 did you go anywhere with this?
from keen-ui.
Any update on this PR?
from keen-ui.
Waiting for @JosephusPaye to review the last bits and release the new version.
from keen-ui.
Most of the bits were merged to the next branch, I suppose @JosephusPaye still has some things he has to prepare before releasing.
Do you need help with anything else, @JosephusPaye?
Meanwhile maybe we can release the next branch as a beta version so it is available in npm?
from keen-ui.
I have made a PR into #552 which solves the issues and provides working examples. Hopefully we can move on now.
from keen-ui.
Great! I will see where I can help with the changelog.
from keen-ui.
Related Issues (20)
- Add `ui-textbox__input-wrapper` around `ui-textbox__input` and `ui-textbox__textarea` HOT 4
- DatePicker: When yearRange is specified with descending array, month selection is broken. HOT 3
- How to dismiss a UiSnackbarContainer? HOT 2
- Missing @types/keen-ui HOT 2
- Having a size undependand on the root node's font-size HOT 3
- position of UiDatepicker not correct when combined with UiPopover/UiMenu HOT 1
- How I get outlined share icon? HOT 3
- Support for autocapitalize property
- ESLint CRLF Windows HOT 6
- Question - Overriding variables.scss HOT 3
- how to add button or link in ui-collasible header HOT 2
- UiSelect not working in Modal HOT 1
- UiSelect selected template HOT 3
- autocomplete on custom case
- UiCalender is not rendering HOT 1
- Dart Sass deprecation warnings HOT 1
- keen-ui.js:8252 [UiRippleInk]: Trigger element not found. HOT 1
- UiSelect can no longer be used correctly in UiPopover HOT 1
- Click on calendar buttons (without type argument) triggers form submit event HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keen-ui.