Binary patterns and Elixir.String.t about gradualizer HOT 7 CLOSED

Hi! I have added two commits for binaries/bitstrings (70a42c2 subtype relation and 37399e4 type checking bit expressions and patterns). Perhaps this helps a bit? It is not really well-tested yet...

from gradualizer.

The gradualizer currently doesn't know anything about Elixir. But it would be really nice to support it! Patches are welcome.
@tim2CF do you have any thoughts on this?

from gradualizer.

Hello!
I'll take a look on this week :)

from gradualizer.

hello, I think this warning is caused by Gradualizer not yet supporting binaries (and binary patterns). If you replace String.t() with binary() you will still get a similar warning.

from gradualizer.

@mbuhot, I believe we've added the support needed for your program to go through Gradualizer. Can you confirm?

from gradualizer.

@josefs I still getting a type error, but now it is consistent whether the function is typed as String.t or binary.

iex(7)> :gradualizer.type_check_module(Foo)
The pattern "#" on line 0 doesn't have the type integer()
:nok

Looks like there is a comment in the tests (https://github.com/josefs/Gradualizer/blob/master/test/should_pass/bitstring.erl#L5-L9) indicating that binary patterns don't type check against binary type specs.

Feel free to close this issue if you'd rather track binary pattern support (independent of Elixir) separately.

from gradualizer.

@mbuhot, thanks for your quick feedback! The error message that you get now is rather puzzling to me but we don't have anyone working on Elixir support so I'm afraid it won't be investigated any time soon. So I'll close this ticket then.

The comment that you pointed to turned out to be outdated and I've updated the test case to reflect that.

from gradualizer.