Code Monkey home page Code Monkey logo

Comments (18)

JoschkaSchulz avatar JoschkaSchulz commented on August 12, 2024 1

Hey, I added version tagging here on github and also uploaded to https://www.npmjs.com/package/cordova-plugin-simple-image-resizer ... sadly the name was already taken that's the reason why I add the (stupid word) simple in it

from cordova-plugin-image-resizer.

JoschkaSchulz avatar JoschkaSchulz commented on August 12, 2024

@keyz182, maybe you could have an idea with that problem?

from cordova-plugin-image-resizer.

keyz182 avatar keyz182 commented on August 12, 2024

@ddoria921 can you try modifying your config.xml to

 <plugin name="cordova-plugin-image-resizer" spec="https://github.com/JoschkaSchulz/cordova-plugin-image-resizer.git" >
    <variable name="ANDROID_EXIFINTERFACES_VERSION" value="27.+" />
</plugin>

It should be setting a default, bit maybe it's being missed?

Typed that on mobile while on the move btw, so be sure to check I got the syntax right.

from cordova-plugin-image-resizer.

ddoria921 avatar ddoria921 commented on August 12, 2024

Nope that didn't fix it.

from cordova-plugin-image-resizer.

keyz182 avatar keyz182 commented on August 12, 2024

from cordova-plugin-image-resizer.

ddoria921 avatar ddoria921 commented on August 12, 2024

The build is failing for me on our build server. Every time I run a build it does a fresh install of the android platform and all the plugins.

When I try to reproduce it locally on my machine I don't get the error. It installs the plugin and builds fine with the proper ANDROID_EXIFINTERFACES_VERSION in the build.gradle file. On my co-worker's machine it fails the same way it does on the build server so I'm not sure what the issue is...

I've tried several different things on my local machine (where all the development happens) to reproduce the issue like:

  • Clearing out all platforms (cordova platform remove android)
  • Clearing out all plugins (rm -rf cordova/plugins/*)
  • rm -rf cordova/node_modules
  • rm -f cordova/package.json cordova/package-lock.json
  • cordova platform add android

In the end it's worked every time on my computer. But still nothing on the build server or my co-worker's machine.

I removed the plugin and had to revert to this commit to get it working. One thing that would help in the meantime is if this plugin had tagged releases that I could point to so I don't have to use the commit hash.

EDIT: fixing grammar

from cordova-plugin-image-resizer.

JoschkaSchulz avatar JoschkaSchulz commented on August 12, 2024

yeah strange... I tried it on my machine too right now... and don't get any errors... everything is working fine. Could it be a problem with the gradle version maybe? I tried it on gradle 4.8 on a mac with the jdk 1.8... I will search around a bit... maybe I find a clue

from cordova-plugin-image-resizer.

keyz182 avatar keyz182 commented on August 12, 2024

I've not been able to recreate or figure out anything potentially wrong I'm afraid. It looks like other plugins use this same method. I don't think it's an issue with gradle, as the variable should be substituted in before gradle is run (as far as I can tell).

@JoschkaSchulz would you be averse to uploading your plugin to NPM? We could pin to versions then that you upload at least.

from cordova-plugin-image-resizer.

ddoria921 avatar ddoria921 commented on August 12, 2024

I also don't think it's an issue with gradle because the variable should be swapped in before it gets to gradle. Also, you don't necessarily have to upload to NPM. You can tag and generate release through GitHub that would allow you to install the plugin at a specific version.

For example to install v1.0 would look like this:
cordova plugin add https://github.com/protonet/cordova-plugin-image-resizer.git#1.0

from cordova-plugin-image-resizer.

huytran0605 avatar huytran0605 commented on August 12, 2024

i got same problem. How can i get old version ?
btw, I'm using cordova-android 6.4 with Android target 26.

from cordova-plugin-image-resizer.

JoschkaSchulz avatar JoschkaSchulz commented on August 12, 2024

I would like to get more information for that... it's really hard to reproduce this error so I can't help. You can just get an older version by removing that code... I have to do an upload to npm of versions that this makes not so much problems in the future again... but for now there is no version tagging

from cordova-plugin-image-resizer.

huytran0605 avatar huytran0605 commented on August 12, 2024

Could you tell me know required package to install current version of this plugin?
Because i saw it need to have exifinterface version > 27? My machine only has 25.1.0 in android-sdk folder.

And I force to update project.properties
cordova.system.library.5=com.android.support:exifinterface:25.1.0
It can build success. But does it makes some bug?

from cordova-plugin-image-resizer.

keyz182 avatar keyz182 commented on August 12, 2024

@huytran0605 I believe anything after or including 25.1.0 will work, but I've not tested. The exifinterface was added in 25.1.0, so won't work on anything earlier.

from cordova-plugin-image-resizer.

huytran0605 avatar huytran0605 commented on August 12, 2024

@keyz182 Unfortunately, I tested and It cannot work :(

from cordova-plugin-image-resizer.

huytran0605 avatar huytran0605 commented on August 12, 2024

@JoschkaSchulz Could you please upload version tagging? Because i use CI to build app so it difficult to install the plugin by manual?
Thanks. I really like and want to use this plugin anymore.

from cordova-plugin-image-resizer.

huytran0605 avatar huytran0605 commented on August 12, 2024

Do you have any idea why in file platforms/android/project.properties used ANDROID_EXIFINTERFACES_VERSION but not exactly any version (25.1.0)
cordova.system.library.2=com.android.support:exifinterface:$ANDROID_EXIFINTERFACES_VERSION

I think in my config it can't read $ANDROID_EXIFINTERFACES_VERSION, so It makes build failed

from cordova-plugin-image-resizer.

sithwarrior avatar sithwarrior commented on August 12, 2024

I spent some time looking at this today.
The problem is that the value replacement for $ANDROID_EXIFINTERFACES_VERSION, dosent work, in older versions of Cordova it seems.
I updated to Cordova 7.1.0 and Cordova-Android 6.4.0 that worked for me.

Another option is to supply the variable at build time, it will then be swaped inside the build.gradle file, and complete the build
cordova build android -- --gradleArg=-PANDROID_EXIFINTERFACES_VERSION=27.+

I created a PR that hardcodes the value to 27.+ #58
That should work, but i dont know, if thats the intended behaviour.

from cordova-plugin-image-resizer.

jetma avatar jetma commented on August 12, 2024

I used cordova plugin add cordova-plugin-simple-image-resizer instead of cordova plugin add https://github.com/protonet/cordova-plugin-image-resizer.git to add the plugin, it worked fine.

from cordova-plugin-image-resizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.