Pass parameters to effects functions? about hyperapp HOT 11 CLOSED

@jbucaran: nope nothing else :) That's perfect. It was the fact that data was missing from the effect function signature that was throwing me. It's there now and all is well :)

from hyperapp.

Ah, so I can pass data to effects -- that's great news! But the docs should really reflect this (they mention data for update-reducers but not effects).

from hyperapp.

Let's say you have this

'use strict'
const { app, html } = hyperapp

app({
  model: {
    text: 'init'
  },
  view: (model) => html`<h1>${model.text}</h1>`,
  hooks: {
    onError: (err) => console.log('huh, err!', err.message) 
  },
  update: {
    first: (model, data) => ({ text: data.text + ' reducer' })
  },
  effects: {
    foo: (model, msg, data, cb) => {
      msg.first({ text: data.text + 'effect '})
      msg.bar({ text: data.text + model.text + ' from foo' })
        .then((message) => {
          throw new Error(message)
        })
        .catch(cb)
    },
    bar: (model, msg, data) => {
      return new Promise((_) => {
        resolve(data.text + 'bar')
      })
    }
  },
  subs: [
    (model, msg) => msg.foo({ text: 'on load ' }) 
  ]
})

from hyperapp.

But since effects don't take any parameters (as per the docs)

That's not true. Every action can be passed with arguments, actually single data argument, through the views. It is easy as msg.action(data). If you want to call other effect from some effect you can do it too.

app({
  effects: {
    foo: (model, msg, data, done) => {
      msg.bar({ bar: data.bar + model.bar + ' from foo' })
    },
    bar: (model, msg, data, done) => console.log(data)
  }
})

from hyperapp.

Yep, we should make the docs better, definitely, haha.

from hyperapp.

@tunnckoCore what does done do?

from hyperapp.

@dodekeract done is that error. it is just options.onError function and it throws given error by default, but you can change this behaviour.

It is just common to call such arguments next, done, cb and etc

edit: because it kinda "follows" the node's "error first callbacks" convention - cb(err).

from hyperapp.

@zaceno It's hard to find, but it's there. I think I can improve this bit of the docs by adding a note to the effects section in the README. Thanks for pointing it out.

from hyperapp.

in addition to the screenshot: "where data is any data you want to pass to the action which is reducer / effect"

from hyperapp.

@tunnckoCore Good point, will fix!

from hyperapp.

@zaceno Docs have been updated. See https://github.com/hyperapp/hyperapp#effects

Let me know if that's good enough or we need to address anything else.

from hyperapp.