Returning empty object where it should not about object.omit HOT 5 OPEN

I think it come from the first If statement in the module:
if (!isObject(obj)) return {};

The RowDataPacket Object seems to not be an object but I don't see how I could make this If statement being true.

from object.omit.

I have found a fix but don't think if it's smart, can you provide a feedback about this ? I added those 3 lines

module.exports = function omit(obj, props, fn) {
  var copy = {};                           // Added line #1
  ObjectCopy(copy, obj)                    // Added line #2
  obj = copy;                              // Added line #3
  if (!isObject(obj)) return {};

And now the isObject(obj) return true !

P.S: Yes I have used your object-copy module ;-)

from object.omit.

Sorry for the late reply, and thanks for the detail. I'll try to take a look today.

Yes I have used your object-copy module ;-)

lol very cool, thank you!

from object.omit.

@sdubrez can you add a complete code snippet that demonstrates the bug so I can easily reproduce? thanks!

from object.omit.

I believe we should not use is-extendable library in order to check whether a value is an object as it's simply confusing and not valid. is-extendable checks whether object is plain, function or array so the whole library won't work on any objects coming from custom class.

from object.omit.