Code Monkey home page Code Monkey logo

Comments (5)

jonobr1 avatar jonobr1 commented on May 22, 2024

Thanks for mentioning this. Remove was one of the latest things I've put in and as such is probably the buggiest. I'll look into this right away.

from two.js.

jonobr1 avatar jonobr1 commented on May 22, 2024

So on further inspection.two.remove(circle); doesn't exist in the API. The way to remove the circle would be to circle.remove();. I will add a two.remove method so that you can do what you'd like. If you'd like to remove all shapes on a page I suggest:

_.each(two.scene.children, function(child) {
  child.remove();
});

Be mindful of removing any references in your own code to shapes and groups in order for the browser to properly garbage collect these.

from two.js.

xixixao avatar xixixao commented on May 22, 2024

Would be good to document this use somewhere in the API, the two descriptions of group.remove() are not very clear to me. Thanks for the snippet, I think this could be result of two.scene.clear().

from two.js.

jonobr1 avatar jonobr1 commented on May 22, 2024

No problem. Indeed — I think I'm gonna craft the api like that. I can update this on the documentation, but yes, remove is odd and takes lineage from backbone's bind and unbind. i.e:

group.remove(circle); // Removes the circle
group.remove(circle, rect); // Removes circle and rect
group.remove([circle, rect]); // Removes circle and rect
group.remove(); // Removes the group itself

from two.js.

jonobr1 avatar jonobr1 commented on May 22, 2024

Added and in the latest build: a5c08c4

from two.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.