Comments (7)
if [[ -z
KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
else
KUBE_PS1_NAMESPACE="default"
fi
I saw the same behavior as well, just was unsure that setting the default to 'default' was going to be accepted. Is there a case where its not default if undefined ?
from kube-ps1.
Remove the -z actually, just test it has output. Verified:
jmosco at jmosco-005715 in ~ (⎈ |minikube:)
$ prompt_k8s
jmosco at jmosco-005715 in ~ (⎈ |minikube:default)
$ kubens
default
kube-public
kube-system
jmosco at jmosco-005715 in ~ (⎈ |minikube:default)
$ kubens kube-public
Context "minikube" modified.
Active namespace is "kube-public".
from kube-ps1.
if [[ -z
$($ {KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}') ]]; then
KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
else
KUBE_PS1_NAMESPACE="default"
fi
haha definitely don't do this, you 're calling kubectl twice just to get the same value :)
${VARIABLE:-default}
should just work here.
from kube-ps1.
Yes, ok lol.
from kube-ps1.
KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
KUBE_PS1_NAMESPACE="${KUBE_PS1_NAMESPACE:-default}"
from kube-ps1.
yeah, but ideally I'd like to see #4 fixed :)
from kube-ps1.
Going to work on that one now. Thanks for all these fixes/suggestions!
from kube-ps1.
Related Issues (20)
- About `KUBE_PS1_SHELL` HOT 2
- Latest VScode 1.74 breaks kube-ps1: character not in range HOT 1
- kubeon/kubeoff does not change prompt when added as oh-my-zsh plugin HOT 10
- display context name HOT 2
- installing in Windows HOT 2
- Running kube_ps1 in bash function returns blank HOT 5
- A few questions about the documentation HOT 1
- multiple prompts HOT 7
- Hide no cluster and default namespace option HOT 2
- Dynamic context colors HOT 3
- Automatically disable kube-ps1 when no context is available HOT 2
- Support fish shell HOT 1
- Add support for Warp HOT 1
- Couldn't Show ☸️ in My Prompt HOT 2
- Ability to display kube-ps1 on the right side of the prompt HOT 1
- Character not in range HOT 2
- Don't work with spaceship theme HOT 3
- Would be great to have Nix Package for kube-ps1
- Multiple prompts if I source .zshrc HOT 2
- Keep kubeoff as default when opening new terminal HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kube-ps1.