seeing empty namespace about kube-ps1 HOT 7 CLOSED

if [[ -z $(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}') ]]; then
KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
else
KUBE_PS1_NAMESPACE="default"
fi

I saw the same behavior as well, just was unsure that setting the default to 'default' was going to be accepted. Is there a case where its not default if undefined ?

from kube-ps1.

Remove the -z actually, just test it has output. Verified:

jmosco at jmosco-005715 in ~ (⎈ |minikube:)
$ prompt_k8s

jmosco at jmosco-005715 in ~ (⎈ |minikube:default)
$ kubens
default
kube-public
kube-system

jmosco at jmosco-005715 in ~ (⎈ |minikube:default)
$ kubens kube-public
Context "minikube" modified.
Active namespace is "kube-public".

from kube-ps1.

if [[ -z $(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}') ]]; then
KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
else
KUBE_PS1_NAMESPACE="default"
fi

haha definitely don't do this, you 're calling kubectl twice just to get the same value :)

${VARIABLE:-default} should just work here.

from kube-ps1.

Yes, ok lol.

from kube-ps1.

KUBE_PS1_NAMESPACE="$(${KUBE_BINARY} config view --minify --output 'jsonpath={..namespace}')"
KUBE_PS1_NAMESPACE="${KUBE_PS1_NAMESPACE:-default}"

from kube-ps1.

yeah, but ideally I'd like to see #4 fixed :)

from kube-ps1.

Going to work on that one now. Thanks for all these fixes/suggestions!

from kube-ps1.