Upstream flamegraph doesn't discard fractional samples about inferno HOT 6 CLOSED

I don't think I've got the mental bandwidth currently to fully implement this as it propagates throughout the program when you make the samples floating point.

In particular, it affects the lookups of TimedFrame due to f64 not having an ordering for Eq nor having a Hash.

I'd gladly leave it for another contributor or for a stream where you get to explain the Fun in why floats don't have decent orderings.

from inferno.

As far as I can tell there is no reason TimedFrame needs to be Eq or Hash. Frame is used as a key in a HashMap, but it doesn't have any fields relating to samples. TimedFrame is only ever stored in a Vec. I think we should be able to use f64 for start_time, end_time, and delta, or am I overlooking something?

from inferno.

I did some digging on this in #64 (comment), and my conclusion from reading brendangregg/FlameGraph#18 is that we should probably simply discard the fractional parts of samples, and add support for --factor instead.

from inferno.

#65 adds --factor instead.

from inferno.

Ah, yes, I think you're right! That would mean that the sample counts are all fractional (probably f64). Would you be willing to write up a PR with that change?

from inferno.

One trick we could play here is to upsample by, say, 100x, and then keep using usize 🤔

from inferno.