Code Monkey home page Code Monkey logo

Comments (11)

jbcden avatar jbcden commented on July 30, 2024 2

Hi @versable I am trying to help out the inferno project which is a rewrite of Flamegraph in Rust. Amoung other improvements to the port, we are looking at existing open changes in this project that we might be able to bring over. Would you be ok with us adapting your PR for SVG improvements for inferno? I am not certain all of the changes apply, but at least a few of them seem very promising!

from inferno.

versable avatar versable commented on July 30, 2024 2

@jbcden, Sure, go ahead. Very interesting project btw, I love it!

from inferno.

ErichDonGubler avatar ErichDonGubler commented on July 30, 2024 1

Ah, derp, sorry, that's my lack of reading. I apologize!

from inferno.

AnderEnder avatar AnderEnder commented on July 30, 2024 1

@versable, looks like this PR is completely in JS, so you can easily backport your changes into: https://github.com/jonhoo/inferno/blob/master/src/flamegraph/flamegraph.js

from inferno.

AnderEnder avatar AnderEnder commented on July 30, 2024 1

@jonhoo, I am waiting for some examples to try generate new regex.

from inferno.

ErichDonGubler avatar ErichDonGubler commented on July 30, 2024

@jonhoo: It looks like there are currently 2 PRs in the queue, one of which you seem to be actively handling (#32) and the other is waiting on the OP to fix some upstream issues they discovered with the PR (#38). Is there anything left for this issue specifically?

from inferno.

jonhoo avatar jonhoo commented on July 30, 2024

@ErichDonGubler ah, so this issue is about PRs to the original Perl implementation that we may be able to port over to the Rust version. I'm sure there are plenty of PRs from there that would be good to port!

from inferno.

versable avatar versable commented on July 30, 2024

Is there any interest in brendangregg/FlameGraph#198? If so, I'd love to get my feet wet with Rust, and this would be really up my alley ;-)

from inferno.

jonhoo avatar jonhoo commented on July 30, 2024

@versable oooh, that seems really neat, so absolutely! I'd be happy to help with a PR :)

from inferno.

AnderEnder avatar AnderEnder commented on July 30, 2024

@jonhoo, What do you think about "Support AsyncProfiler generated stack trace": brendangregg/FlameGraph#234

from inferno.

jonhoo avatar jonhoo commented on July 30, 2024

@AnderEnder That looks like a good thing to support, though the fix looks dubious to me. The proposed regex, ^[^/].*\., matches anything that starts with a non-slash and contains a full stop, which seems overly broad to say "it's Java"?

from inferno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.