Comments (11)
Hi @versable I am trying to help out the inferno project which is a rewrite of Flamegraph in Rust. Amoung other improvements to the port, we are looking at existing open changes in this project that we might be able to bring over. Would you be ok with us adapting your PR for SVG improvements for inferno? I am not certain all of the changes apply, but at least a few of them seem very promising!
from inferno.
@jbcden, Sure, go ahead. Very interesting project btw, I love it!
from inferno.
Ah, derp, sorry, that's my lack of reading. I apologize!
from inferno.
@versable, looks like this PR is completely in JS, so you can easily backport your changes into: https://github.com/jonhoo/inferno/blob/master/src/flamegraph/flamegraph.js
from inferno.
@jonhoo, I am waiting for some examples to try generate new regex.
from inferno.
@jonhoo: It looks like there are currently 2 PRs in the queue, one of which you seem to be actively handling (#32) and the other is waiting on the OP to fix some upstream issues they discovered with the PR (#38). Is there anything left for this issue specifically?
from inferno.
@ErichDonGubler ah, so this issue is about PRs to the original Perl implementation that we may be able to port over to the Rust version. I'm sure there are plenty of PRs from there that would be good to port!
from inferno.
Is there any interest in brendangregg/FlameGraph#198? If so, I'd love to get my feet wet with Rust, and this would be really up my alley ;-)
from inferno.
@versable oooh, that seems really neat, so absolutely! I'd be happy to help with a PR :)
from inferno.
@jonhoo, What do you think about "Support AsyncProfiler generated stack trace": brendangregg/FlameGraph#234
from inferno.
@AnderEnder That looks like a good thing to support, though the fix looks dubious to me. The proposed regex, ^[^/].*\.
, matches anything that starts with a non-slash and contains a full stop, which seems overly broad to say "it's Java"?
from inferno.
Related Issues (20)
- More Firefox rendering issues HOT 1
- `inferno 0.11.8` removed sealed `CollapsePrivate` trait from public API HOT 1
- Lower level API to flamegraph renderer HOT 1
- Color diffusion mode gives less useful results in flamechart mode HOT 2
- Support for simplifying recursive function calls as stackcollapse perl scripts HOT 7
- Support for collapsing source lines from -F+srcline in `perf script` outputs HOT 1
- atty 0.2 has a potential unaligned read HOT 3
- 0.11.15 build fails on Rust 1.62 HOT 1
- Single stack detection can be wrong if the event contains multiple colon HOT 3
- `Input data ends in the middle of a stack.` when using on result of attaching HOT 1
- Differential output tooltips are confusing HOT 4
- Differential output only calculates diff correctly for leaves (most specific frames) HOT 4
- support hot/cold flamegraphs HOT 1
- Document cargo features in readme HOT 1
- flamegraph does not contain sys_enter_* calls with params HOT 3
- Documentation, especially of folded format HOT 3
- publish packages HOT 5
- Error in generated SVG: PCDATA invalid Char value (macos) HOT 5
- Dependencies versions too loose HOT 1
- wallClockProfiler support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inferno.