Comments (1)
Ah. That is a very good point which I hadn't considered.
Constant name sounds like a simpler option.
However, this raising a bigger issue, which is would be a breaking change. If the name of the prefs changes, then any new calls to Once will return incorrect results. This is already happening though if two builds obfuscate the class into different names, a pretty bad bug.
Perhaps the best choice is to replace the PersistedMap.class.getSimpleName()
section with "PersistedMap"
which would ensure existing, non-obsfucated clients wouldn't break
from once.
Related Issues (20)
- [Feature Request] Allow us to specify listeners for Once.initialise() completion HOT 3
- [Feature request] Allow us to retrieve the timestamp when an event was last marked done HOT 7
- How to use, Once times days, minutes HOT 4
- Question about toDo HOT 5
- Got crash error on beenDone from users from google play console HOT 10
- crashes on startup in apk but is working on emulator HOT 9
- NumberFormatException: Invalid long HOT 3
- Get list of tasks that have been done
- I think there is a bug HOT 7
- ConcurrentModificationException HOT 4
- Provide a changelog HOT 2
- ConcurrentModificationException HOT 1
- Migrate away from JCenter HOT 1
- mavenCentral() support HOT 1
- To Do tasks fail to be persisted when force-stopping app HOT 1
- VERSION vs INSTALL tags backwards? HOT 1
- This project uses AndroidX dependencies, but the 'android.useAndroidX' property is not enabled
- Could not find com.jonathanfinerty.once:once:1.2.2 HOT 2
- Differences in publish artifact againt master branch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from once.