"ReadKey" deadlocks with latest StrawberryPerl about termreadkey HOT 6 CLOSED

I can't easily fix it without a windows installation, this does look somewhat like a bug in StrawberryPerl.

I think the best I will be able to do is treat 0 > $ < 1 as 1

from termreadkey.

I've opened a StrawberryPerl bug:
https://rt.cpan.org/Public/Bug/Display.html?id=120043

from termreadkey.

It may be useful if you could paste the generated verision of the ReadKey from the installed ReadKey.pm as it's not clear which one would be used with SP :)

from termreadkey.

The Strawberry Perl upstream's response to my report:

On a MSWin32 ReadKey function looks like this:

sub ReadKey {
my $File = normalizehandle((@>1?$[1]:*STDIN));
if ($[0] || $CurrentMode >= 3) {
Win32PeekChar($File, $[0]);
} else {
getc $File;
}
}

where Win32PeekChar looks like this:

SV * Win32PeekChar(file, delay)
InputStream file
U32 delay <<<<<<<<<<<<<<<<< the trouble!!!
CODE:
{
char key;
if (Win32PeekChar(aTHX_ file, delay, &key))
RETVAL = newSVpv(&key, 1);
else
RETVAL = newSVsv(&PL_sv_undef);
}
OUTPUT:
RETVAL

So calling something like this:

my $x = ReadKey(1e-5);

means that the delay value 1e-5 is converted to U32 (unsigned 32bit integer) which I guess would be 0 (zero), therefore the same as calling my $x = ReadKey(0) - which is exactly what it does (blocking read waiting till you hit any key).

As for the versions:

• Strawberry Perl 5.20.1.1 has TermReadKey-2.31
• Strawberry Perl 5.24.1.1 has TermReadKey-2.37

And if you compare 2.31 vs. 2.37 you will find:

-int Win32PeekChar(PerlIO *file,double delay,char *key)
+int Win32PeekChar(pTHX_ PerlIO *file,U32 delay,char *key)

Note "double delay" vs. "U32 delay"

Full diff:
https://metacpan.org/diff/file?target=JSTOWE%2FTermReadKey-2.37%2F&amp;source=JSTOWE%2FTermReadKey-2.31

So IMHO definitely not a bug Strawberry Perl. ReadKey's Win32PeekChar needs a fix.

from termreadkey.

I'll need to check why that was changed like that in the first place.

from termreadkey.

Thanks for the merge!

from termreadkey.