Comments (6)
We can check if the importmap.php is here and then run the command? Like we already do with packages.json.
Would you mind submitting a PR?
from docker-starter.
We must check the version aswell since the command does not exist in 6.3 and inferior :/.
Sure, if we agree on what should be done !
from docker-starter.
Why? If the file exists, then the components is here, Isn't?
from docker-starter.
The importmap file exists in versions prior to the 6.4 version so no, checking it is not enough.
We should maybe check the .lock file then ? But ehhhh... This is not appealing
from docker-starter.
hmm, I think we can go very simple. This starter is for new project. It does not make sens to start a new project with a SF 6.3. So let's add a simple check on the presence of the file. It's not perfect, but it does the job.
Then if someone use this template with a SF 6.3, they could simply remove 3LOC.
KISS!
from docker-starter.
Sir yes sir 🫡
from docker-starter.
Related Issues (20)
- Expose mysql HOT 1
- Add a Blackfire quick recipe HOT 1
- Forward CI env vars in Docker containers HOT 1
- Find a workaround to have multiple projects running and talking on MacOS HOT 2
- Add a cookbook for pg_activity
- PHP 8 Support ? HOT 2
- Outdated webpack config HOT 1
- Better DX with SSL certificates with mkcert HOT 1
- Add a Dockerfile linter? HOT 4
- probleme 502 bad gateway by nginx HOT 5
- Use M1 compatible base images? HOT 2
- support for Docker Compose v2
- This starter can't be set up without php installed locally HOT 4
- Provide a default Docker registry or layer cache by default HOT 2
- Add a way to leverage exit_code in docker_compose_run commands
- Add License section to the Readme file HOT 1
- Rework a bit how we handler workers HOT 1
- Warning on /services/builder/Dockerfile with apt-key HOT 3
- [RFC] Plugin system HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-starter.