Code Monkey home page Code Monkey logo

Comments (6)

lyrixx avatar lyrixx commented on June 13, 2024

We can check if the importmap.php is here and then run the command? Like we already do with packages.json.

Would you mind submitting a PR?

from docker-starter.

HedicGuibert avatar HedicGuibert commented on June 13, 2024

We must check the version aswell since the command does not exist in 6.3 and inferior :/.

Sure, if we agree on what should be done !

from docker-starter.

lyrixx avatar lyrixx commented on June 13, 2024

Why? If the file exists, then the components is here, Isn't?

from docker-starter.

HedicGuibert avatar HedicGuibert commented on June 13, 2024

The importmap file exists in versions prior to the 6.4 version so no, checking it is not enough.
We should maybe check the .lock file then ? But ehhhh... This is not appealing

from docker-starter.

lyrixx avatar lyrixx commented on June 13, 2024

hmm, I think we can go very simple. This starter is for new project. It does not make sens to start a new project with a SF 6.3. So let's add a simple check on the presence of the file. It's not perfect, but it does the job.

Then if someone use this template with a SF 6.3, they could simply remove 3LOC.

KISS!

from docker-starter.

HedicGuibert avatar HedicGuibert commented on June 13, 2024

Sir yes sir 🫡

from docker-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.