Code Monkey home page Code Monkey logo

Comments (4)

eduard6 avatar eduard6 commented on August 28, 2024

Also happens when no --schedulefile. python tumbler.py wallet.json <addr> = same result.

from joinmarket-clientserver.

AdamISZ avatar AdamISZ commented on August 28, 2024

Yes, for now this is a gap in implementation, and a rather annoying one.

It's quite related to the idea mentioned elsewhere that, the two scripts sendpayment and tumbler really ought to be folded together in this version, since there's some duplication of function; it's better to see tumbler only as a way of generating schedules, nothing else.

The basic sendpayment is now wrongly named since it supports multiple payments and specific schedules can have transactions starting from any mixdepth. But unfortunately, as is noted here the code doesn't currently support starting a tumbler from non-0 mixdepth, only continuing an existing schedule with the --restart option.

Here's one (inferior) way to get round it without code changes: create a tumble schedule normally with python tumbler.py --schedulefile schedule.schedule <tumbler options> wallet.json <addrs> , let it crash as above with No coins error, then edit the schedule.schedule file to increment all the mixdepths (0->1,1->2,..), then run it as a schedule file against sendpayment.py. This option is not good enough though, as it doesn't include the schedule tweaking function which is what makes it more robust.

A better way round it is to create a schedule as above, using one more mixdepth than you actually want, and edit the last value in each entry for mixdepth 0 to 1, which flags it as already complete (for syntax details you've probably already seen this). Then use python tumbler.py --restart --schedule-file schedule.schedule <insert same tumbler options as first start> wallet.json <same addrs>, which should start the tumbler from mixdepth 1 (here assuming that there is no external address in mixdepth 0 payments (that's almost never the case)).

In any case, I should fix this to make it work, apologies.

from joinmarket-clientserver.

AdamISZ avatar AdamISZ commented on August 28, 2024

I'm not sure why I didn't support this in the initial implementation; the original algo (which was simply ported over here with almost no change) supported an arbitrary start depth and I disabled it; I think it was simply a matter of 'worry about that later'. Now that I have "worried" about it (and tested it in a few different configurations), it works fine. The option is -m as per the help. Implemented in 2424104 ; let me know if there's any problem with it.

from joinmarket-clientserver.

eduard6 avatar eduard6 commented on August 28, 2024

Awesome! Worked perfect.

from joinmarket-clientserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.