Comments (4)
Ah yes. I remember having problems with this myself. (It's of course the reason for the setupall.py
script). One thing I found is that there's a mode/flag to python setup.py install
that effectively links to the existing directory, instead of putting it into site-packages
in the virtualenv; I think it might have been -e
, but would have to check.
Re: "this is only an issue for developers", it certainly should be, but it's an annoyance in case a user ever has to edit source files (which they shouldn't, but they may in fact have to with JM as it stands; although only for Maker side usually - and this doesn't handle Makers yet).
In any case, thanks for taking a look, much appreciated.
from joinmarket-clientserver.
Thank you. To add -e
to the pip install
command in setupall.py
is all that is needed. I made changes for setupall.py
to add --develop
mode and wrote instructions for developers (have not yet committed).
But is there a reason to install to site-packages
? I think using the local code for all installs is more convenient and what users expect. It is strange to edit a Python file and have the changes not make any effect. If you agree I will make the needed changes and do a PR.
from joinmarket-clientserver.
Yes, that was it, pip install -e .
But is there a reason to install to site-packages?
I honestly don't know the ins and outs; I think the idea is to completely isolate the installation to the virtualenv, which I guess makes sense? Only surmise, but it seems likely. If your PR has the -e
thing as a --develop
flag, that sounds ideal, yes, I would merge that, thanks! Presumably then the travis test would pass OK as it wouldn't use that (I didn't investigate yet, somehow the imports failed there though).
from joinmarket-clientserver.
Merged #47
There are still open questions here, but for now this seems an acceptable situation.
from joinmarket-clientserver.
Related Issues (20)
- When payjoin fails, should ask for user confirmation for non-payjoin send HOT 2
- feat(rpc): add ability to estimate fee HOT 1
- Random jmdaemon test failure
- Unhandled Twisted Error in yg log: builtins.IndexError: tuple index out of range HOT 2
- Count and display biggest current gap between used addresses of wallet in `wallet-tool.py display`?
- Problem paying with coinjoin with onion directory nodes being down HOT 1
- JoinMarket doesn't handle "Fee estimation disabled" error from Bitcoin Core HOT 2
- Installation hangs on "Downloading config.guess and config.sub" message
- How to change passphrase on wallet? HOT 2
- Shouldn't `receive-payjoin.py` terminate when non-payjoin tx to address is received? HOT 1
- Allow specifying an alternative fee endpoint like mempool.space HOT 4
- Qt: No amount entered isn't handled in "Receive Payjoin" dialog
- QT: Open wallet: keep same wallet selected when entering incorrect passphrase
- Incorrect UTXO status is most often shown for WabiSabi coinjoin outputs
- Assertion failure in test/jmclient/test_wallet_rpc.py:TrialTestWRPC_JWT.test_refresh_token_request HOT 2
- signpsbt do not allow to sign an utxo already spent in an unconfirmed transaction HOT 1
- Support Python minor version HOT 2
- There is no test coverage for `wallet_fetch_history()` / `wallet-tool.py history`
- orderbook: fee and BTC conversion give error response after refreshorderbook
- twisted error when lounching Yield generator HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joinmarket-clientserver.