Add developer instructions about joinmarket-clientserver HOT 4 CLOSED

Ah yes. I remember having problems with this myself. (It's of course the reason for the setupall.py script). One thing I found is that there's a mode/flag to python setup.py install that effectively links to the existing directory, instead of putting it into site-packages in the virtualenv; I think it might have been -e, but would have to check.

Re: "this is only an issue for developers", it certainly should be, but it's an annoyance in case a user ever has to edit source files (which they shouldn't, but they may in fact have to with JM as it stands; although only for Maker side usually - and this doesn't handle Makers yet).

In any case, thanks for taking a look, much appreciated.

from joinmarket-clientserver.

Thank you. To add -e to the pip install command in setupall.py is all that is needed. I made changes for setupall.py to add --develop mode and wrote instructions for developers (have not yet committed).

But is there a reason to install to site-packages? I think using the local code for all installs is more convenient and what users expect. It is strange to edit a Python file and have the changes not make any effect. If you agree I will make the needed changes and do a PR.

from joinmarket-clientserver.

Yes, that was it, pip install -e .

But is there a reason to install to site-packages?

I honestly don't know the ins and outs; I think the idea is to completely isolate the installation to the virtualenv, which I guess makes sense? Only surmise, but it seems likely. If your PR has the -e thing as a --develop flag, that sounds ideal, yes, I would merge that, thanks! Presumably then the travis test would pass OK as it wouldn't use that (I didn't investigate yet, somehow the imports failed there though).

from joinmarket-clientserver.

Merged #47

There are still open questions here, but for now this seems an acceptable situation.

from joinmarket-clientserver.