Code Monkey home page Code Monkey logo

Comments (9)

java-javascript avatar java-javascript commented on August 11, 2024 2

Works for me :). Steps below. Thanks!

# Cleaned and built
git checkout remotes/origin/add-hostname-cfg
mvn clean package -U

# Added the new version of the plugin (removed old versions)
cp target/jmeter-prometheus-plugin-0.6.0-SNAPSHOT.jar ~/jmeter/apache-jmeter-5.2/lib/ext/

# From JMeter Directory
bin/jmeter -Dprometheus.ip=<my ip>

# Prometheus call succeeds
curl http://<my ip>:9270/metrics

# Calls to other IPs fail as expected.

from jmeter-prometheus-plugin.

johrstrom avatar johrstrom commented on August 11, 2024

Hi! Thanks for the ticket, and for the referenced tickets. Especially #32, unfortunately it looked like that person needed to bind to 0.0.0.0 and at the time I didn't know it (I've since had to do similar things with other containers and programs).

But to your main question - there were no plans for it, but I see no reason why not. If you need it, I'm happy to look into it and turn this ticket into a feature request.

from jmeter-prometheus-plugin.

java-javascript avatar java-javascript commented on August 11, 2024

Awesome yeah - a feature request makes sense. Thank you for setting it as such

from jmeter-prometheus-plugin.

johrstrom avatar johrstrom commented on August 11, 2024

I've created this branch add-hostname-cfg and the PR listed above. I tested it out quickly on 127.0.0.1, 0.0.0.0 and my public ip and it all seemed to work just fine. Let me know if it works for you too and I'll pull it in and release it.

from jmeter-prometheus-plugin.

SumantaSarathiChakraborty avatar SumantaSarathiChakraborty commented on August 11, 2024

I was under the same need and this PR resolves it. I have checked it locally. Can we please have this PR released to maven central, please.

from jmeter-prometheus-plugin.

johrstrom avatar johrstrom commented on August 11, 2024

Hi! I'm so sorry, of course I can release this tonight after work.

from jmeter-prometheus-plugin.

SumantaSarathiChakraborty avatar SumantaSarathiChakraborty commented on August 11, 2024

Thanks a lot.

Also, just as I am very new to this plugin, do you have a sample jmx for http request and the plugin configuration (sample jmx provided is with the jsr. So wanted to quickly check with you!)

from jmeter-prometheus-plugin.

johrstrom avatar johrstrom commented on August 11, 2024

To the http question, no I didn't. I used jsr just because I didn't want to hit google or some other api. But the listener configuration would be the same, other than the names of the metrics you're creating.

from jmeter-prometheus-plugin.

johrstrom avatar johrstrom commented on August 11, 2024

Thanks for the call to action. 0.6.0 is released to maven central and I even enabled a badge in the README so folks can just see what version we're working with.

Thanks all!

from jmeter-prometheus-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.