Redo UI about jmeter-prometheus-plugin HOT 5 CLOSED

I've started working on this branch. It is essentially going to wipe the Save dialogue in favour of a bunch of panels like most other jmeter gui elements.

As a design question, now is a good time to decide if we want to continue with the PrometheuSaveConfig class as an abstraction for configurations or if we simply want to access each one by TestElement.getProperty("name_of_property").

Or as a third option that PrometheusSaveConfig class would actually be backed up by the JMeterProperty infrastructure - which may actually be the route to go because then the classes currently using it don't have to change.

I could go either way.

from jmeter-prometheus-plugin.

I think that the third option is the more flexible.
I used local variables to the listener class ( e.g. collectSamples ) to control sample gathering when one of the collector is not active. Probably we should abandon these varibales and use appropriate methods from the PrometheuSaveConfig class.

from jmeter-prometheus-plugin.

I notice that right that collector gathers metrics from any sampler, even those not generating request (eg. beanshell sampler,timer, etc..). This may be misleading when looking that total requests count.
It would be nice to be able to configure the sampler to monitor.

from jmeter-prometheus-plugin.

I agree, I opened this issue for that. I can't get it in this re-factor, but after for sure.

from jmeter-prometheus-plugin.

I'm closing this because we pulled in this re-factor quite some time ago.

from jmeter-prometheus-plugin.