Artist.save_lyrics failing about lyricsgenius HOT 6 CLOSED

Ah, thanks for catching this bug! I think the fix is as changing self.artist to self.name. I'll try to make the fix and update the code tonight.

from lyricsgenius.

Hi, something appears being off still. Minimal script is failing:

import lyricsgenius as genius
access_token = 'XXXX'
api = genius.Genius(access_token)
artist = api.search_artist("The Beatles", max_songs=3)
artist.save_lyrics(format_='json', filename='out.json')

.\python\lyrics>py -3 ./genius.py
Searching for songs by The Beatles...

Song 1: "12-Bar Original"
Song 2: "1822!"
"1 [Booklet]" is not valid. Skipping.
"20 Greatest Hits - Art and Tracklist" is not valid. Skipping.
Song 3: ""Abbey Road" side two"

Reached user-specified song limit (3).
Done. Found 3 songs.
Traceback (most recent call last):
File "./genius.py", line 19, in
artist.save_lyrics(format_='json', filename='out.json')
File "C:\Python3\lib\site-packages\lyricsgenius\artist.py", line 129, in save_lyrics
lyrics_to_write['songs'][-1]['album'] = song.album
File "C:\Python3\lib\site-packages\lyricsgenius\song.py", line 45, in album
if 'album' in self._body and 'name' in self._body['album']:
TypeError: argument of type 'NoneType' is not iterable

.\python\lyrics>py -3 --version
Python 3.6.2

from lyricsgenius.

Shoot, okay. I'll try to take another look in the next couple of days. Thanks for following up.

from lyricsgenius.

@robot3498712 hopefully #75 fixes this bug for you. I was using a sloppy method of accessing elements within the Song object's self._body dictionary, causing an error when the requested field wasn't present in the dict. Let me know if you do run into any more bugs!

from lyricsgenius.

@johnwmillr Thank you, I can confirm issue is fixed. Cheers!

from lyricsgenius.

Hopefully that small change fixes the bug! I had written a test for Artist.save_lyrics, but the test supplies a filename to the function; this bug only shows up when the user doesn't pass a filename in.

from lyricsgenius.