Error while searching for all lyrics by Kanye West about lyricsgenius HOT 7 CLOSED

Worked for me.

from lyricsgenius.

From a new comment on my blog:

Hi John. I seem to be running into the same error as Elijah. I'm not sure if I'm doing something wrong (I'm quite new to Python and programming in general).

It happens with a few artists (for example, Kacey Musgraves, Kanye West, and Taylor Swift).

Here is my code:
songs_by_artist = api.search_artist('Kacey Musgraves')

I get 4 songs, and then an error:
Searching for songs by Kacey Musgraves...

Song 1: "Apologize (Acoustic Version)"
Song 2: "Are You Sure"
Song 3: "A Spoonful of Sugar (from "Mary Poppins")"
"A Very Kacey Christmas [Tracklist + Album Cover]" does not contain lyrics. Rejecting.
Song 4: "A Willie Nice Christmas"

File "C:\Users\Nick\Anaconda2\envs\Playground36TwentyEighteen\lib\site-packages\lyricsgenius\api.py", line 243, in search_artist
lyrics = self._scrape_song_lyrics_from_url(json_song['url'], remove_section_headers)

File "C:\Users\Nick\Anaconda2\envs\Playground36TwentyEighteen\lib\site-packages\lyricsgenius\api.py", line 112, in scrape_song_lyrics_from_url
lyrics = html.find("div", class="lyrics").get_text()

AttributeError: 'NoneType' object has no attribute 'get_text'

I thought this error might be due to using an old version of the package (because I don't run into the same error when running the search myself), but I didn't run into any errors when trying earlier versions either (0.5 and 0.2).

I checked my versions and am using Python 3.6.2, IPython 6.1.0, and lyricsgenius 0.6.3.

from lyricsgenius.

Hey. It's Nick, who reported the bug on your blog.

I took a look at the code and think I found the issue. There are times that a song is in json_search with a URL, but the URL is not valid. For example: https://genius.com/Taylor-swift-acting-like-a-boy-lyrics . The method _scrape_song_lyrics_from_url() then tries to do a .get_text() on class lyrics of the html, but that doesn't exist.

I think the solution is to add another check somewhere in the process to see if the URL is valid and the lyrics exist. I found a quick solution that checks if the lyrics class exists on the URL -- the error doesn't happen and most of the songs are loaded like normal, and for URLs that don't exist the lyrics are a string that is just a space: " ". Of course this isn't ideal and there are better ways to solve it.

If it's alright with you, I'd like to try to solve the issue myself in the next few days. This is my first time working on a project on GitHub and on an open source project, so I think the experience of going through it could help me learn quite a bit of how these things work.

from lyricsgenius.

Great catch! Go for it. Fork the repository then open a pull request back to mine when you’ve come up with a fix.

from lyricsgenius.

Should this issue be closed? Is this solved?

from lyricsgenius.

I think it likely can be closed, but I'm not sure if the problem has been fixed for @NickVance. I was unfortunately never able to recreate the issue he described above.

Do you mind helping out to check if you have the same error he had? Try this command:

songs_by_artist = api.search_artist('Kacey Musgraves', max_songs=8)

If you have the same bug he had, you'll get an error after the 4th song. If you are able to run the code without an error, I'd say we can merge #52 and close this issue.

from lyricsgenius.

Wonderful! Thanks for giving it a try. I'll merge #52 (after fixing the conflicts) and close the issue.

from lyricsgenius.