Code Monkey home page Code Monkey logo

Comments (3)

johnsonsu avatar johnsonsu commented on July 30, 2024 1

Hi @dan-lee , thank you for your suggestions!

That's a great idea, I should definitely include url, name and type in the callbacks. I should be able to get these done this weekend.

Also, I removed the old listener every time because I wanted to make this package super simple. I can do want you wanted by modify the code to store the listeners into an array, but that will put more responsibility to the user of this library, since they will have to control the subscriptions individually. This can make things a little more complicated.

from react-native-sound-player.

johnsonsu avatar johnsonsu commented on July 30, 2024 1

Sorry for the delay, but the new version is now available with more control over event listeners. Thank you for your support!

from react-native-sound-player.

dan-lee avatar dan-lee commented on July 30, 2024

@johnsonsu Thanks for your reply. I see your concern and would propose something like a one time subscription or maybe returning an unsubscribe callback.
Something like:

SoundPlayer.on('FinishedLoading', )
SoundPlayer.once('FinishedLoading', )

// or (similar like actual addEventListener from the DOM)
SoundPlayer.on('FinishedLoading', callback, { once: true })

// or 
const unsubscribe = SoundPlayer.on('FinishedLoading', )
// later on… 
unsubscribe()

from react-native-sound-player.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.