Comments (3)
Hi @dan-lee , thank you for your suggestions!
That's a great idea, I should definitely include url
, name
and type
in the callbacks. I should be able to get these done this weekend.
Also, I removed the old listener every time because I wanted to make this package super simple. I can do want you wanted by modify the code to store the listeners into an array, but that will put more responsibility to the user of this library, since they will have to control the subscriptions individually. This can make things a little more complicated.
from react-native-sound-player.
Sorry for the delay, but the new version is now available with more control over event listeners. Thank you for your support!
from react-native-sound-player.
@johnsonsu Thanks for your reply. I see your concern and would propose something like a one time subscription or maybe returning an unsubscribe callback.
Something like:
SoundPlayer.on('FinishedLoading', …)
SoundPlayer.once('FinishedLoading', …)
// or (similar like actual addEventListener from the DOM)
SoundPlayer.on('FinishedLoading', callback, { once: true })
// or
const unsubscribe = SoundPlayer.on('FinishedLoading', …)
// later on…
unsubscribe()
from react-native-sound-player.
Related Issues (20)
- On Creation of apk HOT 5
- [BUG] setNumberOfLoops not a function
- Cannot hear sounds in ios version 13 and can hear sounds in ios version 12 HOT 3
- [BUG] Sound keeps playing if the app is killed manually HOT 1
- Add new event listener which returns the current duration as the audio progresses. HOT 3
- Audio not playing[BUG]
- [BUG]: TypeError: Cannot read property 'playSoundFile' of null HOT 1
- [ERROR] Build failed with ios HOT 1
- Invariant Violation with IoS
- Is this repo actively maintained? HOT 1
- [BUG] - Android - SoundPlayer.loadUrl crash HOT 2
- [Question] I have a question!! HOT 2
- No sound received when App is in background/kill mode HOT 1
- [BUG] play multiple sounds HOT 2
- [BUG] iOS silence mode doesn't play on .playUrl HOT 1
- [BUG] when playing sounds, it crashes with saying attempt to invoke virtual method 'void.android.media.MediaPlayer.setOnCompletionListener HOT 1
- [iOS] Problem listening FinishedLoading & FinishedPlaying HOT 5
- [BUG] accumulation of addEventListener callbacks when using fast-reload HOT 1
- [BUG] playAsset does not work in Android release mode
- [BUG] playAsset and loadAsset are missing from index.d.ts HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-sound-player.