Comments (3)
johnpapa
commented on August 11, 2024
good catch, yes, please make a PR!
from vscode-angular-snippets.
Gelio
commented on August 11, 2024
I have created a PR for this issue (#57). Thank you for responding, It's an honor to be able to talk to you, not to mention contribute to one of your projects! I'm a big fan, basically.
I was also wondering if the type annotation for this EventEmitter isn't redundant. We already have type inference since we're assigning an instance of EventEmitter to this property and when it comes to other properties with an explicit type annotation tslint shows an error, for instance:
It may not be the same since EventEmitter is not a primitive type, but I reckon that dropping that annotation would result in a bit tidier codebase. What do you think?
from vscode-angular-snippets.
johnpapa
commented on August 11, 2024
i removed the extra type too. thanks
published in 2.3.3
from vscode-angular-snippets.
Related Issues (20)
- Express configuration support requires workspace access - breaks extensionKind 'ui' HOT 1
- Faulty implementation of the 'a-route-params-subscribe' snippet HOT 3
- Not appearing in Nuget package manager search in visual studio 2019 HOT 1
- This extention make a problem with manifest.json : Incorrect type. Expected "array"
- Add latest release HOT 1
- Broken image on VSCode marketplace
- Add a comma at the end of the sentence
- Support Workspace Trust
- Support virtual workspaces
- Publish to open vsx registry
- Add returntype everywhere
- Why does the ngFor-TrackBy html extension create a "item.id" and not use a function call? HOT 1
- Enable Angular Snippets to run on VS Code on the web HOT 6
- Feature Request - Storybook snippets
- ng template snippets is outdated HOT 1
- Automate build/publish HOT 1
- CanActivate is deprecated. Provide a snippet for CanActivateFn HOT 1
- [Feature Request] Can We Have ngOn* function snippet?
- Add control flow snippets HOT 3
- Name: Angular 2 TypeScript Test Snippets Id: MarinhoBrandao.Angular2Tests Description: Angular 2 TypeScript test snippets (updated up to Angular 2.1.2) Version: 0.7.3 Publisher: Marinho Brandao VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=MarinhoBrandao.Angular2Tests HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-angular-snippets.