Comments (9)
FWIW,
http://www.a.com, ...
yieldshttp://www.a.com, ...
, however appending a slashhttp://www.a.com/, ...
yields (note the trailing punctuation is included in the link)<a href="http://www.a.com/," target="_self">http://www.a.com/,</a> ...
- and separating links with multiple spaces (spaces not preserved by Markdown)
http://www.a.com http://www.b.com
yields<a href="http://www.a.com" target="_self">http://www.a.com</a> <a href="//www.b.com" target="_self">www.b.com</a>
from ember-linkify.
Thanks for opening this issue! Definitely agree that we should support this better. When I get a chance I will dive into the regex a bit to see how I can get the expected output to be produced.
from ember-linkify.
+1 for this.
from ember-linkify.
+1
from ember-linkify.
Version 3.0.0 handles space delimited list of URLs as expected now
from ember-linkify.
Want me to split the comma-delimited issue into a separate issue? IMO that's the more likely use-case.
from ember-linkify.
@nwhittaker I'll reopen it so we're tracking against the punctuation case.
from ember-linkify.
@nwhittaker I have a PR for this. Can you drop in and give some input?
from ember-linkify.
Any way to detect the delimiter programmatically? Or at least make a best guess? I suspect the typical usage of this helper (at least it is in my case) is to pass it dynamic or user-entered content. So the delimiter isn't always knowable (or guaranteed consistent) ahead of time.
from ember-linkify.
Related Issues (18)
- Add strict option
- Support ip addresses in urls HOT 2
- Support "rel" attribute HOT 2
- Add a linkify component HOT 2
- Don't include punctuation in link HOT 1
- Trailing newlines are stripped HOT 4
- Readme doesn't state target possibility HOT 2
- Does not respect html handed to text attribute. HOT 2
- URLs with fragments without a leading '/' not supported HOT 4
- Use default ember transitions for internal links HOT 3
- Localhost links aren't recognised
- Update babel
- Target attribute HOT 2
- ember-linkify generates deprecation warning with latest ember: ember-cli-babel 5.2.4->6.6
- ember-linkify does not work with the latest Ember (3.7) HOT 1
- Add `tmp` dir to the .npmignore. HOT 1
- Use new Helper API HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-linkify.