Code Monkey home page Code Monkey logo

Comments (9)

nwhittaker avatar nwhittaker commented on August 28, 2024

FWIW,

  • http://www.a.com, ... yields http://www.a.com, ..., however appending a slash http://www.a.com/, ... yields (note the trailing punctuation is included in the link) <a href="http://www.a.com/," target="_self">http://www.a.com/,</a> ...
  • and separating links with multiple spaces (spaces not preserved by Markdown) http://www.a.com http://www.b.com yields <a href="http://www.a.com" target="_self">http://www.a.com</a> <a href="//www.b.com" target="_self">www.b.com</a>

from ember-linkify.

johno avatar johno commented on August 28, 2024

Thanks for opening this issue! Definitely agree that we should support this better. When I get a chance I will dive into the regex a bit to see how I can get the expected output to be produced.

from ember-linkify.

netes avatar netes commented on August 28, 2024

+1 for this.

from ember-linkify.

killerbytes avatar killerbytes commented on August 28, 2024

+1

from ember-linkify.

kamikaz1k avatar kamikaz1k commented on August 28, 2024

Version 3.0.0 handles space delimited list of URLs as expected now

from ember-linkify.

nwhittaker avatar nwhittaker commented on August 28, 2024

Want me to split the comma-delimited issue into a separate issue? IMO that's the more likely use-case.

from ember-linkify.

kamikaz1k avatar kamikaz1k commented on August 28, 2024

@nwhittaker I'll reopen it so we're tracking against the punctuation case.

from ember-linkify.

kamikaz1k avatar kamikaz1k commented on August 28, 2024

@nwhittaker I have a PR for this. Can you drop in and give some input?

from ember-linkify.

nwhittaker avatar nwhittaker commented on August 28, 2024

Any way to detect the delimiter programmatically? Or at least make a best guess? I suspect the typical usage of this helper (at least it is in my case) is to pass it dynamic or user-entered content. So the delimiter isn't always knowable (or guaranteed consistent) ahead of time.

from ember-linkify.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.