Spotify API Inconsistency: Integer Values Returned as Floats Without Documentation Update about spotifyapi-net HOT 6 CLOSED

This issue seems to be happening to multiple developers, including myself, and has been discussed previously in #925, #926 and #928. For me, it randomly stopped happening after few days.

from spotifyapi-net.

This issue seems to be happening to multiple developers, including myself, and has been discussed previously in #925, #926 and #928. For me, it randomly stopped happening after few days.

I'm aware that this was discussed. I raised the issue out of #925 to further spread awareness for it.

The Newtonsoft.JSON Deserializer should convert int to double if int is returned from the API and double is expected. Thats why the approach of changing the types might work long term.

from spotifyapi-net.

Well I should read all the discussions beforehand. It seems the Serializer has been modified to convert.

My bad!

from spotifyapi-net.

Hi @Inzaniity,
I'm also experiencing the JsonReaderException on some properties, for instance album.total_tracks. Updating to the latest SpotifyAPI.Web (7.1.1) did not fix them all.

If I add the DoubleToIntConverter attribute to the properties that still cause the exceptions it's ok again.

So it seems to me we should add the DoubleToIntConverter attribute to all int properties so it doesn't break when Spotify decides to return doubles/floats somewhere. What do you think?

from spotifyapi-net.

Hi @Inzaniity, I'm also experiencing the JsonReaderException on some properties, for instance album.total_tracks. Updating to the latest SpotifyAPI.Web (7.1.1) did not fix them all.

If I add the DoubleToIntConverter attribute to the properties that still cause the exceptions it's ok again.

So it seems to me we should add the DoubleToIntConverter attribute to all int properties so it doesn't break when Spotify decides to return doubles/floats somewhere. What do you think?

I mean that is what I did but on an older code base. So yeah, converting all expected ints seems to be the solution here.

from spotifyapi-net.

A Spotify developer confirmed a fix for this in the discussion on the Spotify developer forum

An optimization in the deserialization of JSON in upstream was causing the serializer to default to double types for integer values. The optimization was not applied to all queries, and several tools were sanitizing the response which was the reason we did not uncover this from the start.

from spotifyapi-net.