Code Monkey home page Code Monkey logo

Comments (6)

johnkary avatar johnkary commented on May 28, 2024

@REBELinBLUE It's not currently possible to set different slowness thresholds on a per-test suite basis. But I would love to add that feature.

How are you defining the test suites in your project? Would you mind posting an example?

from phpunit-speedtrap.

REBELinBLUE avatar REBELinBLUE commented on May 28, 2024

Thanks :) I'm just defining them using the tag in the phpunit config file

from phpunit-speedtrap.

johnkary avatar johnkary commented on May 28, 2024

@REBELinBLUE What might be the best way to disable the listener?

Setting an extremely high slownessThreshold like 999999 would prevent a test reporting slow unless it ran for more than 999 seconds. However a more intentional threshold of 0 might be better. We already use reportLength = 0 to display all slow tests in the output instead of trimming to 5.

What if the SpeedTrapListener supported configuring test suites by supplying the testsuite name? The options configuration could be defined as an array of arrays, where each array has:

  • testSuiteName
  • slownessThreshold
  • reportLength

The XML configuration would look like this for 2 test suites... what do you think?

<phpunit
    backupGlobals               = "false"
    backupStaticAttributes      = "false"
    colors                      = "true"
    convertErrorsToExceptions   = "true"
    convertNoticesToExceptions  = "true"
    convertWarningsToExceptions = "true"
    processIsolation            = "false"
    stopOnFailure               = "false"
    syntaxCheck                 = "false"
    bootstrap                   = "vendor/autoload.php">
    
    <testsuites>
        <testsuite name="Database Test Suite">
            <directory>src/*/*/*/Tests/Database</directory>
        </testsuite>
        <testsuite name="Not Database Test Suite">
            <directory>src/*/*/*/Tests</directory>
            <exclude>
                <directory>src/*/*/*/Tests/Database</directory>
            </exclude>
        </testsuite>
    </testsuites>
    
    <listeners>
        <listener class="JohnKary\PHPUnit\Listener\SpeedTrapListener">
            <arguments>
                <array>
                    <element>
                        <array>
                            <element key="testSuiteName">
                                <string>Database Test Suite</string>
                            </element>
                            <element key="slowThreshold">
                                <integer>0</integer>
                            </element>
                        </array>
                    </element>
                    <element>
                        <array>
                            <element key="testSuiteName">
                                <string>Not Database Test Suite</string>
                            </element>
                            <element key="slowThreshold">
                                <integer>500</integer>
                            </element>
                            <element key="reportLength">
                                <integer>0</integer>
                            </element>
                        </array>
                    </element>
                </array>
            </arguments>
        </listener>
    </listeners>
</phpunit>

from phpunit-speedtrap.

REBELinBLUE avatar REBELinBLUE commented on May 28, 2024

Awesome, thanks that sounds ideal :)

from phpunit-speedtrap.

torkiljohnsen avatar torkiljohnsen commented on May 28, 2024

@johnkary It would be great if we could use the @slowThreshold annotation on classes too, not just test methods 🙂

from phpunit-speedtrap.

martinbean avatar martinbean commented on May 28, 2024

Is this on the roadmap at all? I’m in the exact same boat (got an integration test suite that has “slow” tests that I’d like to increase the threshold on).

from phpunit-speedtrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.