Code Monkey home page Code Monkey logo

Comments (5)

erunion avatar erunion commented on May 28, 2024

$test in the SpeedTrapListener ::endTest method is typecasted to PHPUnit_Framework_Test, so having it look for it being an instance of PHPUnit_Framework_TestCase won't work.

Honestly, the problem here is that your setUpBeforeClass just shouldn't be throwing exceptions. Fix that and everything else works.

from phpunit-speedtrap.

Thomblin avatar Thomblin commented on May 28, 2024

Well,

in the described case, PHPUnit_Framework_TestSuite is send to SpeedTrapListener::endTest (no idea why), which implements PHPUnit_Framework_Test but not PHPUnit_Framework_TestCase, which is expected in getSlowThreshold()

from phpunit-speedtrap.

marcaube avatar marcaube commented on May 28, 2024

I'm having the same problem with a skipped test, this is indeed a real issue.

class SlowApiTest extends PHPUnit_Framework_TestCase
{
    public static function setUpBeforeClass()
    {
        if (!getenv('SKIP_CONDITION')) {
            self::markTestSkipped('foo');
        }
    }

    // ...
}

from phpunit-speedtrap.

erunion avatar erunion commented on May 28, 2024

I've pushed up a fix into #13 for this.

from phpunit-speedtrap.

johnkary avatar johnkary commented on May 28, 2024

Thank you so much for reporting the issue and the detailed way to recreate it! This issue has been fixed in 160af2e.

from phpunit-speedtrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.