Dictionary Bugs about foliate HOT 5 CLOSED

Funny enough, I've just added the option to disable dictionary in 5c9c9bc before even seeing this issue.

I think it's extremely unfair to call it "spamming" or "Distributed Denial of Service". It's simply querying one page (two at most, if the word contains capital letters and was not found, it tries for an all lowercase version), based on explicit, well-defined user action.

I'm also very clear about the data coming from Wiktionary -- noted both on the website as well as in the lookup popover.

I do plan on adding more dictionary options eventually, although this is a relatively arduous task, so it might not happen very soon. See also #5. As for the lookup-on-selection behavior, it's related to highlight-on-selection discussed in #9.

from foliate.

Thanks for the quick reply! Apologies for the DDoS remarks...

from foliate.

@johnfactotum Bug testing results:

After removing the old flatpak, cleaning the '.var' folder for leftover app settings, and installing the 1.1.0, there is now a new bug that prevents the disabling of dictionary, although the checkbox exists in UI:

Step 1. Click on 'Enable dictionary', but it stays always checked

Commentary: The gschema in dconf does not seem to have 'lookup-enabled' ( data/com.github.johnfactotum.Foliate.gschema.xml). maybe an old file or resource is the problem?

Console messages:

flatpak run com.github.johnfactotum.Foliate
Gjs-Message: : JS WARNING: [resource:///com/github/johnfactotum/Foliate/js/main.js 1086]: reference to undefined property "webView"

(com.github.johnfactotum.Foliate:2): Gjs-WARNING **: : JS ERROR: TypeError: this.webView is undefined
scriptRun@resource:///com/github/johnfactotum/Foliate/js/main.js:1086:9
buildMenu/<@resource:///com/github/johnfactotum/Foliate/js/main.js:1582:17
main@resource:///com/github/johnfactotum/Foliate/js/main.js:1861:12
run@resource:///org/gnome/gjs/modules/package.js:225:12
@/app/bin/com.github.johnfactotum.Foliate:9:1

from foliate.

dconf-editor will not show the lookup-enabled key if you're using flatpak and doesn't have a value set for that key, because the flatpak version installs the schema in a private directory.

Is this the full output? Something is seriously wrong with your install, as the script couldn't even find the webview. If it's a schema problem it should say Settings schema 'com.github.johnfactotum.Foliate' does not contain a key named 'lookup-enabled' or something along those lines. So it doesn't seem to me that that is the problem here.

from foliate.

Thanks for the feedback.

Yes, flatpak was the problem. Directly building and installing with the meson build system is a fix. 'lookup-enabled appeared'.

You can mark this issue closed, if you want.

from foliate.