Comments (5)
Funny enough, I've just added the option to disable dictionary in 5c9c9bc before even seeing this issue.
I think it's extremely unfair to call it "spamming" or "Distributed Denial of Service". It's simply querying one page (two at most, if the word contains capital letters and was not found, it tries for an all lowercase version), based on explicit, well-defined user action.
I'm also very clear about the data coming from Wiktionary -- noted both on the website as well as in the lookup popover.
I do plan on adding more dictionary options eventually, although this is a relatively arduous task, so it might not happen very soon. See also #5. As for the lookup-on-selection behavior, it's related to highlight-on-selection discussed in #9.
from foliate.
Thanks for the quick reply! Apologies for the DDoS remarks...
from foliate.
@johnfactotum Bug testing results:
After removing the old flatpak, cleaning the '.var' folder for leftover app settings, and installing the 1.1.0, there is now a new bug that prevents the disabling of dictionary, although the checkbox exists in UI:
Step 1. Click on 'Enable dictionary', but it stays always checked
Commentary: The gschema in dconf does not seem to have 'lookup-enabled' ( data/com.github.johnfactotum.Foliate.gschema.xml). maybe an old file or resource is the problem?
Console messages:
flatpak run com.github.johnfactotum.Foliate
Gjs-Message: : JS WARNING: [resource:///com/github/johnfactotum/Foliate/js/main.js 1086]: reference to undefined property "webView"
(com.github.johnfactotum.Foliate:2): Gjs-WARNING **: : JS ERROR: TypeError: this.webView is undefined
scriptRun@resource:///com/github/johnfactotum/Foliate/js/main.js:1086:9
buildMenu/<@resource:///com/github/johnfactotum/Foliate/js/main.js:1582:17
main@resource:///com/github/johnfactotum/Foliate/js/main.js:1861:12
run@resource:///org/gnome/gjs/modules/package.js:225:12
@/app/bin/com.github.johnfactotum.Foliate:9:1
from foliate.
dconf-editor will not show the lookup-enabled
key if you're using flatpak and doesn't have a value set for that key, because the flatpak version installs the schema in a private directory.
Is this the full output? Something is seriously wrong with your install, as the script couldn't even find the webview. If it's a schema problem it should say Settings schema 'com.github.johnfactotum.Foliate' does not contain a key named 'lookup-enabled'
or something along those lines. So it doesn't seem to me that that is the problem here.
from foliate.
Thanks for the feedback.
Yes, flatpak was the problem. Directly building and installing with the meson build system is a fix. 'lookup-enabled appeared'.
You can mark this issue closed, if you want.
from foliate.
Related Issues (20)
- Any chance for an AppImage version ? HOT 1
- Option to open PDFs in external app
- Resizing one foliate instance would causes the other foliate instance will also resize HOT 2
- Allow trusted books to load contents from the internet HOT 3
- Segfault(often but not always) when copying text HOT 1
- Bookmark not Working on .mobi File
- how to change the theme from dark to light.
- Consistent crash upon expanding the annotation type menu HOT 2
- Zooming in in PDFs HOT 4
- Foliate crashes upon adding OPDS url HOT 4
- unable show after open, need to go into library and select the book HOT 5
- Foliate is unable to find books after #ecd9a15f HOT 5
- Dual Screen Mode HOT 1
- ebooks lost after restart HOT 4
- feat: mouse back button should work like browser HOT 1
- When in remote repositories (Internet archive, ect built in), the screen flashes HOT 5
- Open links in foliate HOT 3
- Dict lookup failed with sdcv installed HOT 3
- FR: Use paragraph number for citation HOT 1
- no javascript file in epub 3 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foliate.