Comments (5)
Fixed in version 1.2.1, released today.
For what it's worth, the Flake8 dependency of Flake8-pyproject was pinned to < 6
before this release. So I don't see why Flake8 needed to be pinned separately (as in those mentions). This should have been handled automatically by Pip's dependency solver. And it was, in my experience. I had no issues with CI.
Flake8 v6 did introduce some breaking changes with the new major version (as it does, and which is why the pin was put in place), but they didn't affect the parsing of pyproject.toml
, as far as I can tell, only of Flake8's INI-like config files.
from flake8-pyproject.
I don't know why pip's dependency solver didn't work either, we got these failures when it was unpinned:
https://github.com/DiamondLightSource/python3-pip-skeleton/actions/runs/3541575749/jobs/5946003894
Either way, with the new release and flake8 unconstrained works:
https://github.com/DiamondLightSource/python3-pip-skeleton/actions/runs/3564433455
Thanks for the quick release!
from flake8-pyproject.
Thanks for the feedback, @coretl. Yeah, that's strange. It installed flake8==2.3.0
(super old) and Flake8-pyproject==0.9.1
(quite old). No idea why it did that, but not surprised to see that combination break. Maybe I should just remove the version pin entirely if it does not have the intended effect. There are good arguments against it after all.
from flake8-pyproject.
I always stated that upper constraints are armed time-bombs. Unless you already know that next version will break, don't add the constraint.
How can you know?
- a breaking pre-release or release was already made
- the development branch already has a breaking change in
- the maintainer of the dependency already announced some changes that are affecting you
Based on my experience most projects survive major version bumps w/o having to change a thing.
pinning... is a nuke.
from flake8-pyproject.
@ssbarnea Can you explain why the dependency resolution failed in the above case?
from flake8-pyproject.
Related Issues (14)
- Flake8 `--config` option not supported HOT 11
- Running via Flake8 pre-commit hook HOT 4
- Remove upper pinning for flake 8 and add test for flake8 main HOT 1
- Support `flake8:local-plugins` HOT 6
- the name case HOT 1
- parse_args() used in hook.py HOT 6
- Alternatives to this project? HOT 12
- Flake8-pyproject doesn't work with flake8 `6.1.0` HOT 2
- Unrecognized argument toml config HOT 2
- Override `flake8` script? HOT 6
- Does not support Flake8 5+ HOT 1
- `flake8p` is only aware of `pyproject.toml` in the current folder HOT 1
- Error with `flake8-mock` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flake8-pyproject.