Support GitHub Flavored Markdown about dillinger HOT 12 CLOSED

+1

from dillinger.

+1

from dillinger.

Pull requests accepted! =)

This would require a clientside version of github flavored markdown and a node module. They may both exist and if so let me know and I'll add them.

from dillinger.

Touchée! Will investigate and maybe start implementing (and learn to node.js) tomorrow. Open Source, fuck yeah!

from dillinger.

Sounds good!

from dillinger.

So... It would seem that your app does support GFM (at least most of it).

These features have been implemented within showdown.js for the GFM preview page (repo) and you can see them in your showdown.js tagged with GFM.

However the dev candy features of Fenced code blocks and Syntax highlighting were never implemented and probably never will as they later on deprecated the live preview in favor of the preview link wherever markdown is available, which is rendered server-side. Also these features are not implemented in github_markdown_preview, another project which uses the same showdown.js, either.

So back to square one: no existing implementation, should either patch showdown.js or make a new node module.

from dillinger.

Thanks for the update. Shall I go ahead and close? Or do you think you may be working on a patch?

from dillinger.

I'll close for now, will reopen (or open another more specific one) by next week should I have time to spare.

from dillinger.

so, after addyosmany twit today and also mathiasbynens twit I ended up hacking some simple code to add syntax highlight and fenced code blocks support, should be trivial to merge this kind of change.

I know that the syntax support will need more patches since highlight.js doesn't understand js as a language, only javascript - a simple dictionary should be able to translate all the alias to the proper language names tho...

anything else missing?

from dillinger.

just reminded about another thing, GFM nowadays is different from the parser that GitHub uses to parse README.md files, newlines are treated differently (README files you can hard wrap lines, on comments preview you can't). I had to edit showdown on mdoc to avoid line breaks.

from dillinger.

Cool! Did you commit this to showdown or do you have fork somewhere?

from dillinger.

I haven't forked it, I just did the replacements before running showdown (for the code blocks) and commented the line that adds the line breaks... The proper way of doing it would be to fork showdown and add some configuration support to it, but since I hacked the mdown live preview in <30min and mdoc in less than 1 day I didn't really spent too much time doing things the "right way".

from dillinger.