with $ref, the generated referred to class is named incorrectly about jsonschema2pojo HOT 6 CLOSED

From [email protected] on April 20, 2011 10:45:43
Discussion on this:
http://groups.google.com/group/jsonschema2pojo-users/browse_thread/thread/4ae73b8ee6c64060

from jsonschema2pojo.

From [email protected] on December 01, 2012 05:34:12
As a quick and dirty fix for this [I am assuming my schema locations a filenames and the filename is alphabets plus underscore (_) only and is followed by .json; but one can do some thing more sophisticated in the same vein):
--- a/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/JsonSchemaRule.java
+++ b/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/JsonSchemaRule.java
@@ -57,13 +57,17 @@ public class JsonSchemaRule implements SchemaRule<JClassContainer, JType> {

     if (schemaNode.has("$ref")) {
         schema = ruleFactory.getSchemaStore().create(schema, schemaNode.get("$ref").asText());

+String[] parts = schemaNode.get("$ref").asText().split("[^A-Za-z_]");
+String guessedName = parts[parts.length - 2];
schemaNode = schema.getContent();

         if (schema.isGenerated()) {
             return schema.getJavaType();
         }

•        return apply(nodeName, schemaNode, generatableType, schema);
  

•        return apply(guessedName, schemaNode, generatableType, schema);
   } 
  

from jsonschema2pojo.

From [email protected] on December 01, 2012 05:35:32
On a related note - worth raising a separate issue I would think; I don't want a $extends $ref to generate a class named XXXParent either, for that my other quick and dirty fix:
diff --git a/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/ObjectRule.java b/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/ObjectRule.java
index 3373a69..790f1b3 100644
--- a/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/ObjectRule.java
+++ b/jsonschema2pojo-core/src/main/java/com/googlecode/jsonschema2pojo/rules/ObjectRule.java
@@ -183,7 +183,10 @@ public class ObjectRule implements SchemaRule<JPackage, JType> {
private JType getSuperType(String nodeName, JsonNode node, JClassContainer jClassContainer, Schema schema) {
JType superType = jClassContainer.owner().ref(Object.class);
if (node.has("extends")) {

•        superType = ruleFactory.getSchemaRule().apply(nodeName + "Parent", node.get("extends"), jClassContainer, schema);
  

•        String[] parts = node.get("extends").get("$ref").asText().split("[^A-Za-z_]");
  

•        String guessedName = parts[parts.length - 2];
  

•        superType = ruleFactory.getSchemaRule().apply(guessedName, node.get("extends"), jClassContainer, schema);
   }
   return superType;
  

  }

from jsonschema2pojo.

From [email protected] on December 01, 2012 06:12:09
One could come up with a more sophisticated URI to java class name conversion mechanism:

1. first don't assume a flat packaging but mimic the relative URI structures of the schemas
   2)SomeFile ==> SomeFile
   SomeFile.json => SomeFile_json
   SomeFile.X.json => SomeFile_X_json
   Some_File.json => Some__File_json <= basically _ is escaped
   3)Of course a simpler means would be to use a property (e.g. javaType) in the schema file (if it exists) as the POJO name. (while this is documented in the extentions - it doesn't work as expected

from jsonschema2pojo.

From [email protected] on December 01, 2012 18:33:44
@tseringshrestha I would think that the javaType property could allow you to workaround your problems. What problem did you have with it?

from jsonschema2pojo.

Resolving this as a dupe of #164 as there's a better, cleaner, description of the problem there.

from jsonschema2pojo.