Code Monkey home page Code Monkey logo

Comments (7)

priithaamer avatar priithaamer commented on May 14, 2024 1

Hey, thanks for pointing out where to start! I was reading through the code earlier and it is also easy to follow. Anyway, i will start working on it soon.

from navalia.

joelgriffith avatar joelgriffith commented on May 14, 2024 1

Been a few days! The Chrome module now supports this (I'm working on getting it into the Navalia Module next).

npm i --save [email protected] 🎉

from navalia.

joelgriffith avatar joelgriffith commented on May 14, 2024

I think this is a fabulous idea, and definitely within the realm of this project! I'd love to see a PR if you're willing to try out a contribution 😄

There's a few place you can start: the first by adding a parameter to Navalia's constructor to specify where the browsers are. When starting chrome, you can pass in a port for remote debuggers to connect, which is what you'd have to do. As far as the API might go, I think something like:

const navalia = new Navalia({
  chromeOptions: {
    remote: ['http://www.my-site.com:1234', 'http://www.my-site.com:4567'],
  }
});

Navalia starts Chrome here, so we'll need to alter some utilities to allow passing in an existing chrome instance. There'd also be other work in the "cleanup" portion of the library as well, as Navalia will try and close these on shutdown or when maximums are reached here, which we probably don't want it to do.

Let me know if how I can help guide or give feedback, but definitely say give it a shot! We're open to it!

from navalia.

joelgriffith avatar joelgriffith commented on May 14, 2024

I can take care of all the tedious parts (docs, changelog, releasing), so don't worry about those ceremonious tasks

from navalia.

joelgriffith avatar joelgriffith commented on May 14, 2024

Hey @priithaamer, just checking in with you on this. I can knock this out if it's a blocker for you?

from navalia.

priithaamer avatar priithaamer commented on May 14, 2024

Hey, i'm not in a hurry with this. Feel free to work on more urgent issues. Currently, i have my own wrapper for chrome-remote-interface that is quite similar to navalia. However, i would like to use well maintained library eventually and this project here is a perfect replacement.

from navalia.

priithaamer avatar priithaamer commented on May 14, 2024

Whoa, that was quick! I'll try it out in the next couple of days.

from navalia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.