Code Monkey home page Code Monkey logo

Comments (4)

fice-t avatar fice-t commented on August 20, 2024

@joddie I made a fix for this in #16, and it seems to work.

Though one of the tests (macrostep-expand-and-collapse) did fail for a naive fix shown here. Where is the priority property used outside of checking if it's equal to 1?

from macrostep.

joddie avatar joddie commented on August 20, 2024

Yes, the priority overlay property has a special meaning to Emacs: when there are several overlays at a point, all with different values for SOME-PROPERTY, priority determines which of them overrides the other. See the Elisp manual node "Overlay Properties".

I think your PR is probably good but I have a couple of questions which I will ask over there.

from macrostep.

joddie avatar joddie commented on August 20, 2024

Forgot to add: macrostep needs to be able to determine the innermost overlay when there are multiple levels of expansion. This is done by setting priority to higher values for each successive level of expansion, which explains why the expand-and-collapse test would fail without ti.

from macrostep.

fice-t avatar fice-t commented on August 20, 2024

Right, I was searching around in macrostep.el for explicit uses of priority and somehow thought that since it seemed to work in trivial cases that it wasn't actually being used as normal. My bad.

from macrostep.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.