Comments (4)
@joddie I made a fix for this in #16, and it seems to work.
Though one of the tests (macrostep-expand-and-collapse
) did fail for a naive fix shown here. Where is the priority property used outside of checking if it's equal to 1?
from macrostep.
Yes, the priority
overlay property has a special meaning to Emacs: when there are several overlays at a point, all with different values for SOME-PROPERTY
, priority
determines which of them overrides the other. See the Elisp manual node "Overlay Properties".
I think your PR is probably good but I have a couple of questions which I will ask over there.
from macrostep.
Forgot to add: macrostep
needs to be able to determine the innermost overlay when there are multiple levels of expansion. This is done by setting priority
to higher values for each successive level of expansion, which explains why the expand-and-collapse
test would fail without ti.
from macrostep.
Right, I was searching around in macrostep.el
for explicit uses of priority
and somehow thought that since it seemed to work in trivial cases that it wasn't actually being used as normal. My bad.
from macrostep.
Related Issues (17)
- Buffer is modified after a macroexpansion HOT 3
- Macro expansions should not be recorded in the undo history. HOT 1
- Backquote behaves oddly in macroexpansions
- Possibly spurious colon HOT 1
- any chance of making this work with macrolet? HOT 14
- Expand macro in another buffer HOT 4
- `macrostep-expand` fails with error on erroneous macros HOT 3
- `macrostep-expand` fails with a "Scan error" unlike `eval-last-sexp` HOT 1
- Tag 0.9 for MELPA stable build => slime 2.17 depends on it HOT 2
- Should expand autoloaded macros HOT 1
- ...is not a macro form
- when expansion value is "", the original macro isn't reinserted on quit
- makefile macrostepper
- Use #' instead of function in expand form
- Use keywords for define-minor-mode HOT 1
- New failures with native-compilation on emacs-next-minimal-30.0.50-1.9d27b95
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from macrostep.