Allow inline runsettings arguments about dotnet-test-rerun HOT 16 CLOSED

Hi @Silv-1,

Thanks for creating this issue.
We will try to work on this during this week.

from dotnet-test-rerun.

I will fix that as well as this issue soon.
Sorry been unable to pick it up in between.

from dotnet-test-rerun.

I have issues with the runsettings parameters

Executing something similar to this

test-rerun /path/to/Solution.sln --configuration Release --logger trx -
-filter TestCategory=TestSuite_Suite1 --rerunMaxAttempts 1 -- MSTest.Parallelize.Workers=4

returns error

Unrecognized command or argument 'MSTest.Parallelize.Workers=4'

from dotnet-test-rerun.

Hi @Silv-1 ,

The problem was that the library we are using don't recognize that command. In order to have some control and provide feedback when the input is wrong we've added a new input called --inlineRunSettings.
After adding that and separated by spaces each configuration you can add the input that you wanted.

So using as example -- MSTest.Parallelize.Workers=4 that would be called with --inlineRunSettings MSTest.Parallelize.Workers=4 which will then called dotnet test in the right way.

Please test with this version: https://www.nuget.org/packages/dotnet-test-rerun/1.8.0-alpha.2

from dotnet-test-rerun.

@Silv-1 ,

When you see the need for other parameters let us know by opening the issue.
We don't currently support all the options from dotnet test only the ones identified as useful until now.

from dotnet-test-rerun.

I saw the multiple loggers are already implemented, awesome! Just the commits seem to have referenced #95 instead of #94 in the message.

from dotnet-test-rerun.

Already opened the PR for this.

Could you please test both issues with this alpha version: https://www.nuget.org/packages/dotnet-test-rerun/1.8.0-alpha.1 ?

Let us know the outcome.

from dotnet-test-rerun.

thanks for the great library! +1 vote from me on adding support for RunSettings parameter.

from dotnet-test-rerun.

@Silv-1 will check why that is not working.

Thanks for the feedback.

from dotnet-test-rerun.

Multiple --logger arguments and multiple --inlineRunSettings arguments work like a charm.

Tested https://www.nuget.org/packages/dotnet-test-rerun/1.8.0-alpha.2.

Thank you very much. 🙏

from dotnet-test-rerun.

Released this officially in version https://www.nuget.org/packages/dotnet-test-rerun/1.8.0
Please test and close the issue if everything is as expected

from dotnet-test-rerun.

The problem was that the library we are using don't recognize that command.

System.CommandLine does support the -- token. The -- Token.

IIRC they show up in the InvocationContext.ParseResult.UnparsedTokens, but you probably know this already.

Anyway, don't mean to sidetrack. Thanks for this library. Looks like it might help me from writing a PS script on my own.

from dotnet-test-rerun.

Hi @DavidAllardyce,

Yes, it is exactly that. It will show in the unparsed tokens and because of a configuration we've activated it will throw an error.

The feedback provided by that configuration adds good value as feedback. So we thought it would add more value to name the configuration but support the same behaviour by doing a map to what is done in dotnet test.

Regarding the tool thanks for the feedback.

Based on our initial use case we've created a second tool called https://github.com/ricardofslp/dotnet-trx-merge
Take a look to see if it could be useful.

from dotnet-test-rerun.

Hi @Silv-1 ,

Is it ok to close the two issues?

from dotnet-test-rerun.

@ricardofslp inline run settings worked for us, thanks!

from dotnet-test-rerun.

Works in the official release.

Tested https://www.nuget.org/packages/dotnet-test-rerun/1.8.0.

from dotnet-test-rerun.