Code Monkey home page Code Monkey logo

Comments (2)

JoanZapata avatar JoanZapata commented on July 26, 2024

I don't see any particular problem with getPaint() method, you're free to send a PR. :-)

But people may not know when to call it to set specific settings, and if you want to set antialiasing or anything else to all your icons, you'd need to configure them one by one.

What about a method like that in IconDrawable?

protected void configurePaint(Paint paint){
     // Meant to be overriden
}

Then if you want different configuration you can override it and use your AntialiasIconDrawable wherever you need it. Opinion?

I know about the composition over inheritance thing, but I think that the Drawable you're trying to get is a specialization of the one that exists by default.

from android-iconify.

DayS avatar DayS commented on July 26, 2024

That's better 👍

from android-iconify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.