Code Monkey home page Code Monkey logo

Comments (5)

jnsh avatar jnsh commented on August 26, 2024

Thank you for the report.

What WM/Desktop and application is the delete dialog from?
Also, how does the dialog look with default theme, and/or how exactly you'd prefer it to look?

There are no plans for variants with major differences in styling, as there's no easy way of making this configurable for every supported desktop and toolkit. I think such variants should be developed as separate forks.

from arc-theme.

clumsyfingers avatar clumsyfingers commented on August 26, 2024

hi, its on gnome but is the same also on budgie. its just the standard delete dialogue in nautilus
here its shown with plata, qogir and arc darker https://imgur.com/a/1X4Jdcd
its just that top bar in arc thats ugly imho

from arc-theme.

jnsh avatar jnsh commented on August 26, 2024

I see. Apparently the bar isn't visible on Adwaita either, so it makes sense to follow upstream on this.

I'll fix this at some point, but it's not the highest priority at the moment.
Pull requests are welcome, if anyone wants to help with this.

from arc-theme.

jnsh avatar jnsh commented on August 26, 2024

Bit of a status update.

I investigated this awhile ago and it seemed that the modal dialog titlebar styling was intentional design choice from the original designer, and already present in the first version of the theme IIRC. Therefore I wouldn't like to remove it. Additionally it seemed that changing this would require quite big reorganizing of the theme stylesheet.

IMHO the biggest visual issue with the current design is that there's no padding between the titlebar and the modal dialog message, which makes it look unbalanced. I was thinking about merely adding some padding there, rather than removing the titlebar altogether.

Let me know if you have any feedback on this, or any other suggestions.

from arc-theme.

jnsh avatar jnsh commented on August 26, 2024

I've added some padding between the dialog titlebar and content in a394a76, which IMHO looks much nicer:

Screenshot from 2022-02-17 15-58-01

If anyone still wants to get rid of the dialog titlebar, it can be done with simple CSS injection, e.g.:
For GTK3, ~/.config/gtk-3.0/gtk.css:

messagedialog .titlebar {
  background-color: @theme_bg_color;
  border-bottom: none;
  box-shadow: none;
}

messagedialog box.dialog-vbox.vertical {
  padding-top: 0;
}

For GTK4, ~/.config/gtk-4.0/gtk.css:

window.dialog.message .titlebar {
  background-color: @theme_bg_color;
  border-bottom: none;
  box-shadow: none;
}

window.dialog.message box.dialog-vbox.vertical {
  padding-top: 0;
}

Closing.

from arc-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.