Code Monkey home page Code Monkey logo

Comments (12)

jmrozanec avatar jmrozanec commented on May 30, 2024

@JensWalter thanks for forking cron-utils! Would you mind merging forked changes into a new branch?

from cron-utils.

JensWalter avatar JensWalter commented on May 30, 2024

Sure, but so far I didn't came to the point where I could actually test my implementation. So far I only got to the point where it compiles.
So I could merge it back, but the current status is rather experimental. So should I merge back or first try to test a little more?

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

If current status is experimental, I would prefer if you can test it more. Quality matters!
Can I assign the issue to you? Thanks!

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

Once we have this branch, it would be great to setup different classifiers, to produce compatible versions for different JDKs. A resource on this here

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

@JensWalter Hi! are you still willing to migrate this project to JDK8?
If doing so, it would be an opportunity to get rid of guava, since there were some complaints on how heavy that dependency is, and in JDK8 we have full support for Functions.

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

We are migrating cron-utils to JDK8. This task will be developed on branch jdk8
With this migration effort we are also removing guava dependency, in order to avoid unnecessary dependencies on libraries.

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

Migration to JDK8 was done. Replacing JodaTime for Java Time remains.

from cron-utils.

espiegel avatar espiegel commented on May 30, 2024

@jmrozanec
For replacing JodaTime with Java 8's API do we want to migrate all methods that return a joda time "DateTime" object with Java 8's "LocalDateTime" or "ZonedDateTime" ?

I'm leaning towards "LocalDateTime". Just wondering what are your thoughts on this matter.

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

@espiegel we are willing to replace all methods regarding Jodatime "DateTime". This would be a major change. I would lean towards ZonedDateTime, since better reflects behavior "DateTime" provides us today. Note that there are several cases, where DateTime gives us a notion of timezone where the time was being used.

from cron-utils.

espiegel avatar espiegel commented on May 30, 2024

@jmrozanec Sounds good, I'll get started on that later this week.

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

@espiegel Great! Looking forward to merge the changes!

from cron-utils.

jmrozanec avatar jmrozanec commented on May 30, 2024

@JensWalter The feature was contributed by @espiegel at PR#107 Thank you @espiegel for tackling this!

from cron-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.