Specifying multiple files results in bad compilation about grunt-browserify HOT 5 CLOSED

Full error stack

Uncaught TypeError: Cannot set property 'exports' of undefined scripts.js:9785
defineExport scripts.js:9785
browserifyShim scripts.js:9783
browserifyShim scripts.js:9785
require.en0Fjs scripts.js:9789
s scripts.js:1
(anonymous function) scripts.js:1
require../chat scripts.js:747
s scripts.js:1
e scripts.js:1
(anonymous function)

from grunt-browserify.

@shama, any thoughts on this? Thinking it's an issue with g-b's interface to grunt, since the file contents are exactly the same...

from grunt-browserify.

It looks like something isn't getting wrapped properly if module is undefined. I'm having trouble reproducing though. @Fauntleroy Could you post your example to a repo where we can download and test?

from grunt-browserify.

I'm running into the same issue. What I'm seeing is that shim'ed modules get wrapped n times by browserifyShim, where n is the index of file being compiled in files.

For example, if I have a browserify config like this:

files: {
  'a': ['a.js'],
  'b': ['b.js']
},
options: {
  shim: {
    'swfobject': {
      path: 'lib/swfobject.js',
      exports: 'swfobject'
    }
  },

and both "a" and "b" require('swfobject'):

"a"'s swfobject shim will work correctly:

var global = self;
(function browserifyShim(module, exports, define, browserify_shim__define__module__export__) {
...

but "b"'s swfobject will wrap the module two times:

var global = self;
(function browserifyShim(module, exports, define, browserify_shim__define__module__export__) {
    (function browserifyShim(module, exports, define, browserify_shim__define__module__export__) {
...

from grunt-browserify.

That makes sense then. shims is defined outside the forEachSeries processing of files; moving inside the iterator function should solve the problem, I think. I'll take a look this weekend.

from grunt-browserify.