Overload Stomp.client to take a subprotocol about stomp-websocket HOT 4 CLOSED

I'm not sure to follow you.

This library requires using the STOMP 1.0 protocol (and 1.1, 1.2 when the lib when I update it). The STOMP protoocol defines what's goes in the WebSocket frames.

If I were to add a subprotocol, I would hardcode it to be v10.stomp, then v11.stomp, etc. but not let the client define it. Or am I misunderstanding the subprotocol thing?

from stomp-websocket.

Jeff,

WebSockets allow more than one 'subprotocol' to access a given URI. The
server needs to be able to select one. If its unspecified, it has to
default.

Why is it needed?

Well, we have begun an implementation where STOMP, AMQP 1.0, WAMP and MQTT
can all be used on the same URI, which represents a queue (we might even
add a REST binding to the same URI; the jury's out).

The value of the 'subprotocol' should only be versioned for a significant
breaking change - in my view, STOMP v1.0 and v1.1 can happily co-exist,
because there is enough for the server to distinguish one from another.
Others might have a different view. I agree that it is hardcoded - the
client should not be able to change it.

The reason for the overload is that there are WebSockets servers which do
not support multiple protocols (or even receiving one protocol) - mostly
because they grew up with the historic drafts.

Raph

Chief Architect, stormmq
Secretary, OASIS AMQP Standard
[email protected]
+44 7590 675 756

UK Office:
Hamblethorpe Farm, Crag Lane, Bradley BD20 9DB, North Yorkshire, United
Kingdom
Telephone: +44 845 3712 567

Registered office:
16 Anchor Street, Chelmsford, Essex, CM2 0JY, United Kingdom
StormMQ Limited is Registered in England and Wales under Company Number
07175657
StormMQ.com

On 24 October 2012 16:51, Jeff Mesnil [email protected] wrote:

I'm not sure to follow you.

This library requires using the STOMP 1.0 protocol (and 1.1, 1.2 when the
lib when I update it). The STOMP protoocol defines what's goes in the
WebSocket frames.

If I were to add a subprotocol, I would hardcode it to be v10.stomp, then
v11.stomp, etc. but not let the client define it. Or am I misunderstanding
the subprotocol thing?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-9744714.

from stomp-websocket.

Raph, does this PR match your requirements?

from stomp-websocket.

Jeff,

Yes, I think that should work. Thank you for considering the change.

Raph

Raphael Cohn
Chief Architect, stormmq
Secretary, OASIS AMQP Standard
[email protected]
+44 7590 675 756

UK Office:
Hamblethorpe Farm, Crag Lane, Bradley BD20 9DB, North Yorkshire, United
Kingdom
Telephone: +44 845 3712 567

Registered office:
16 Anchor Street, Chelmsford, Essex, CM2 0JY, United Kingdom
StormMQ Limited is Registered in England and Wales under Company Number
07175657
StormMQ.com

On 5 November 2012 14:03, Jeff Mesnil [email protected] wrote:

Raph, does this PR match your requirements?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-10071339.

from stomp-websocket.