Comments (6)
Thanks for pointing that out. I've put an email in to a couple lawyer friends who specialize in open source licensing.
from elodie.
@waynew Looks like the solution is to omit LatLon from the pip package and instruct the user that they'll need to install it manually. Simply using LatLon isn't a violation but once we package it up we convey that Elodie is GPL.
Does pip let you add a message upon successful installation?
from elodie.
It looks like we're only using LatLon to convert between degrees/minutes/seconds and decimal degrees, is that right? It might be easier to just do that conversion inline, rather than including the GPL dependency, as the formula is pretty simple for it: http://www.rapidtables.com/convert/number/degrees-minutes-seconds-to-degrees.htm
from elodie.
Huh, I see you already have functions for this in the geolocation module! Any reason not to just use those instead? This might also help with some of the precision issues, since it looks like the geolocation code is using Fraction instead float (like LatLon does).
from elodie.
@noonat good point. Looks like we can just swap out usage of LatLon
with the geolocation module. It will require the tests to be updated though. I'll try to have a look in the next couple days if someone else doesn't get to it before me.
from elodie.
LatLon removed in PR gh-83.
from elodie.
Related Issues (20)
- api key generation fails HOT 3
- keywords based dynamic albums HOT 1
- imghdr going away
- Crash on text file NOT containing us-ascii or utf-8 in first line
- feature: able to create symlinks instead of copying
- Calculate checksum of image without EXIF-data
- Unknown Location - invalid AppKey HOT 14
- Support a time offset in addition to absolute time
- ISO 8601 datetime without capitalising the rest of the filename? HOT 1
- Dockerfile no longer resolves to a valid url for Exiftool download
- Dockerfile no longer works with debian:jessie as the base
- Unexpected int returned instead of string from metadata[part] in filesystem.py HOT 1
- Will there be an official Elodie docker image published on the cloud (ie not the Dockerfile) ?
- Elodie not recognizing videos with the .mkv file extension HOT 2
- Feature request: support for NRW and RAF files
- config.ini ignored HOT 5
- Hard to tell what the problem is when there's errors importing files HOT 7
- Need to add a test: adding a file which is already in destination
- CircleCI URL for exiftool returns 404
- Use local database for geolocation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elodie.