Code Monkey home page Code Monkey logo

Comments (6)

jmathai avatar jmathai commented on May 18, 2024

Thanks for pointing that out. I've put an email in to a couple lawyer friends who specialize in open source licensing.

from elodie.

jmathai avatar jmathai commented on May 18, 2024

@waynew Looks like the solution is to omit LatLon from the pip package and instruct the user that they'll need to install it manually. Simply using LatLon isn't a violation but once we package it up we convey that Elodie is GPL.

Does pip let you add a message upon successful installation?

from elodie.

noonat avatar noonat commented on May 18, 2024

It looks like we're only using LatLon to convert between degrees/minutes/seconds and decimal degrees, is that right? It might be easier to just do that conversion inline, rather than including the GPL dependency, as the formula is pretty simple for it: http://www.rapidtables.com/convert/number/degrees-minutes-seconds-to-degrees.htm

from elodie.

noonat avatar noonat commented on May 18, 2024

Huh, I see you already have functions for this in the geolocation module! Any reason not to just use those instead? This might also help with some of the precision issues, since it looks like the geolocation code is using Fraction instead float (like LatLon does).

from elodie.

jmathai avatar jmathai commented on May 18, 2024

@noonat good point. Looks like we can just swap out usage of LatLon with the geolocation module. It will require the tests to be updated though. I'll try to have a look in the next couple days if someone else doesn't get to it before me.

from elodie.

jmathai avatar jmathai commented on May 18, 2024

LatLon removed in PR gh-83.

from elodie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.