Code Monkey home page Code Monkey logo

Comments (10)

jlmakes avatar jlmakes commented on August 17, 2024

Thanks for this Sonny,

Oddly enough, they both work on my phone (mobile Safari) and neither work on my laptop (Chrome). I’ll run some more tests on v0.0.4. We’ll get this fixed.

from scrollreveal.

sonnypgs avatar sonnypgs commented on August 17, 2024

Thanks for getting this fixed.

You're right, neither is working in Chrome.
I've tested it using Safari (v 7.0.1) and FireFox (v 27.0.1) on Mac OS X 10.9.1 Mavericks.

from scrollreveal.

sonnypgs avatar sonnypgs commented on August 17, 2024

Thank you for the fix Julian.

Unfortunately it's still not working properly on my end - same browsers & OS.
http://jsfiddle.net/sonnypgs/4S6E7/6/
I'm able to see the elements fading in for half a second, but then they will disappear immediately.

I'll run some more tests in the coming days and keep you posted.

from scrollreveal.

jlmakes avatar jlmakes commented on August 17, 2024

I just pushed a commit updating the data-attributes, so make sure you update your data-attributes to data-scroll-reveal not data-scrollReveal.

I ran some tests on v0.0.4 and ran into issues as you described—but everything appears to be working correctly in Chrome, Safari and Firefox (OSX 10.9.2) for v0.1.0 on my end.

I loaded your JSFiddel…

I didn’t have much luck including the external resource, so I just included the minified library directly: http://jsfiddle.net/4S6E7/9/

I see what you’re saying, it’s re-initializing the elements when reset: false is set (which is actually default, you don’t need to manually declare that) — which does not happen outside of JSFiddle in my testing…

Can you recreate the problem outside of JSFiddle? I’m thinking I could capture the initial style states outside of the update function, perhaps in the init() method… that might fix this, but I’m curious if this is a JSFiddle-only issue.

from scrollreveal.

jlmakes avatar jlmakes commented on August 17, 2024

@sonnypgs

Try this one: http://jsfiddle.net/4S6E7/10/

Working as expected? Minor change, but if it works I’ll commit the change.

from scrollreveal.

sonnypgs avatar sonnypgs commented on August 17, 2024

Yep I'm currently working on a website, on which I'm encountering the same problem.
I just recreated the scenario in JSFiddle.
...
Awesome http://jsfiddle.net/4S6E7/10/ works flawlessly 👍

from scrollreveal.

jlmakes avatar jlmakes commented on August 17, 2024

In that case, I’ll commit the change…

from scrollreveal.

sonnypgs avatar sonnypgs commented on August 17, 2024

Alright, thank you :)

Works fine in Chrome, Safari, Opera & Firefox.

from scrollreveal.

jlmakes avatar jlmakes commented on August 17, 2024

Grab the latest copy, everything should be in order now. 😎

from scrollreveal.

sonnypgs avatar sonnypgs commented on August 17, 2024

Confirmed 👍 :)

from scrollreveal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.