Comments (9)
@jlmakes friendly ping!
from karma-rollup-preprocessor.
Hey! I wanted to leave a note that I was seeing the same behavior of an endless loop of re-writing and watching the tests file when autoWatch: true, singleRun: false
. I also implemented a quick fix of downgrading to 7.0.7
and am investigating locally.
from karma-rollup-preprocessor.
I've looked into this one and here is what I found.
-
The changes made for #72 introduced this issue.
-
rollup.watch
is used instead ofrollup.rollup
.rollup.watch
also writes directly to the file system, resulting in this issue. -
I think that the root cause of #72 is in
@rollup/plugin-typescript
when usingrollup.rollup
(i.e. watchMode is false) -
I created an issue in
@rollup/plugin-typescript
rollup/plugins#1354 -
I also created a pull request in
@rollup/plugin-typescript
rollup/plugins#1356.
Once rollup/plugins#1354 is fixed and released, the fix for #72 could be reverted and everything should work as expected when using the official Typescript plugin.
from karma-rollup-preprocessor.
@jlmakes would you consider releasing a new version with this fix? The current v7.0.8 has this issue...
from karma-rollup-preprocessor.
@jlmakes any chance you could have a look please? :)
from karma-rollup-preprocessor.
We hit this issue as well and downgrading resolved the problem. (Internal project, no link to share)
from karma-rollup-preprocessor.
I see, that's no good! Roping @YonatanKra into this conversation. Let's see if we can get this fixed, thanks for the report.
from karma-rollup-preprocessor.
The pull request for @rollup/plugin-typescript
was approved and released as part of version 10.0.1.
I created a pull request #76 to revert the changes that introduced this issue and added a basic test case.
from karma-rollup-preprocessor.
@jlmakes LMK if you think the change can be integrated
from karma-rollup-preprocessor.
Related Issues (20)
- Rollup has moved output options within the config
- sourcemaps not working HOT 4
- Add support of array configs HOT 4
- Source Maps not Working HOT 1
- Watching doesn't start when debugging HOT 4
- Not compatible with the latest version of Rollup (v1.0.0) HOT 2
- TypeError: Cannot read property 'forEach' of undefined HOT 4
- dynamic imports give a 404 HOT 4
- dependencies are duplicated for each test file HOT 19
- Issues using babel-typescript and @types packages HOT 3
- Watching fails to process files HOT 6
- Missing options in examples HOT 2
- Warnings when used with Rollup >= 1.27.0
- There are hints when using plug-ins that introduce files HOT 1
- @rollup/plugin-multi-entry broken by #54 HOT 6
- Watch not working on windows HOT 9
- #69 breaks configs with output.file HOT 1
- Watcher not working using TypeScript? HOT 13
- New version containing fix for watch mode HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karma-rollup-preprocessor.