Code Monkey home page Code Monkey logo

Comments (6)

JLLeitschuh avatar JLLeitschuh commented on May 18, 2024

@Tapchicoma you want to take a crack at this one? Can you add some simple Junit tests that cover this too for us?

from ktlint-gradle.

Tapchicoma avatar Tapchicoma commented on May 18, 2024

@JLLeitschuh yeah, I will take a look.

In version 0.10.0 ktlint introduced multiple reporters support. I think this is the cause.

from ktlint-gradle.

JLLeitschuh avatar JLLeitschuh commented on May 18, 2024

@Tapchicoma Hijacking this issue for a second, come chat with me either in the gitter chat or find me in the Kotlin Slack (slack is better for me).

from ktlint-gradle.

leinardi avatar leinardi commented on May 18, 2024

Quick and dirty fix:

private fun isReportAvailable(version: String, availableSinceVersion: String): Boolean {
    val versionsNumbers = version.split('.')
    val reporterVersionNumbers = availableSinceVersion.split('.')
    return versionsNumbers[0].toInt() >= reporterVersionNumbers[0].toInt() &&
            versionsNumbers[1].toInt() >= reporterVersionNumbers[1].toInt() &&
            versionsNumbers[2].toInt() >= reporterVersionNumbers[2].toInt()
}

from ktlint-gradle.

JLLeitschuh avatar JLLeitschuh commented on May 18, 2024

We may want to consider doing our parsing with this library:
https://github.com/zafarkhaja/jsemver.
Might be overkill though.

from ktlint-gradle.

Tapchicoma avatar Tapchicoma commented on May 18, 2024

@leinardi little improve your fix, but solution is right.

from ktlint-gradle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.