Comments (3)
Actually, i don't think there is a better way to do this. Actually, this is pretty interesting. This falls into the crap that they don't document. There's so much of it, it kills me. As far as the Mojo work, I think you have the grasp of the injection code, and that's pretty much the hardest part.
Anyways, I did a refactor so that we had some better logical separation and fixed some of your code quality issues. The code quality is set pretty crazy high on this project, regarding documentation and funny java quirks. I'm not going to lie, after using this for a while, it's the reason I started looking at other languages (Groovy, Scala, JRuby) that had less quirks (at least less that required me to keep doing mind numbing tasks). When I pulled your code down, it didn't compile because of the checkstyle errors. Did you get to test it?
As I mentioned in the pull request, I tested it using the test project. I'll make sure to check that in.
from closurejavascriptframework.
Yes, you are right about the checkstyle, it was failing for me and I silently commented the plugin out during testing on my side
I added two more commits into PR. Feel free to look at them and update as needed.
That would be probably it... I like how the code is right now and I am looking forward to the next release to use the new functionality. Though, do not hesitate to let me know if there is anything I can help you with.
from closurejavascriptframework.
Looks good, and I'll drop out a release today. Thanks for the help Lukas!
from closurejavascriptframework.
Related Issues (20)
- Verify that the sourceDirectory build parameter is honored HOT 2
- Make a video on how to do testing HOT 1
- Add an option for generating synchronously loading debug and assert libraries.
- Sync debug and assert files should not always use the configured output wrapper.
- Upgrade to the most recent compiler version HOT 11
- extend gitignore for IntelliJ IDEA HOT 1
- Issues parsing test results based on goog.testing.ContinuationTestCase HOT 4
- Upgrade selenium version to get support of CORS in HtmlUnit HOT 1
- Upgrade selenium version to get support of CORS in HtmlUnit library HOT 4
- Allow browser version configuration for HtmlUnitDriver
- Investigate JsCompRun integration HOT 2
- Closure Compiler upgrade HOT 3
- Allow user to specify path of extracted closure-library <HOME> folder HOT 3
- Skip tests - how to? HOT 7
- skipTests not honoured if property value set in profile HOT 5
- JavaDoc copy&paster issue
- Configurable warning levels HOT 1
- Unable to move files to war archive directory on empty maven module HOT 1
- Closure's deps.js file is not included by default
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from closurejavascriptframework.