[closure-compiler-maven-plugin] enable --@define compiler command line option about closurejavascriptframework HOT 3 CLOSED

Actually, i don't think there is a better way to do this. Actually, this is pretty interesting. This falls into the crap that they don't document. There's so much of it, it kills me. As far as the Mojo work, I think you have the grasp of the injection code, and that's pretty much the hardest part.

Anyways, I did a refactor so that we had some better logical separation and fixed some of your code quality issues. The code quality is set pretty crazy high on this project, regarding documentation and funny java quirks. I'm not going to lie, after using this for a while, it's the reason I started looking at other languages (Groovy, Scala, JRuby) that had less quirks (at least less that required me to keep doing mind numbing tasks). When I pulled your code down, it didn't compile because of the checkstyle errors. Did you get to test it?

As I mentioned in the pull request, I tested it using the test project. I'll make sure to check that in.

from closurejavascriptframework.

Yes, you are right about the checkstyle, it was failing for me and I silently commented the plugin out during testing on my side 😄. I wanted to look at it later after we sort out the basic idea of this PR. Anyway, thanks for looking at this [checkstyle] issue.

I added two more commits into PR. Feel free to look at them and update as needed.

That would be probably it... I like how the code is right now and I am looking forward to the next release to use the new functionality. Though, do not hesitate to let me know if there is anything I can help you with.

from closurejavascriptframework.

Looks good, and I'll drop out a release today. Thanks for the help Lukas!

from closurejavascriptframework.