jrmapi/src/main/java/module-info.java:[5,25] module not found: net.lingala.zip4j about jrmapi HOT 4 CLOSED

rm src/main/java/module-info.java works around this.

from jrmapi.

Hi,

thanks for your issue report. Astounding is a modular project for Java11, and I want it to keep being like this. The issue is that the developer of the zip4j library rejected my PR to modularize its library, as it would then require Java11 to compile:

srikanth-lingala/zip4j#217

To solve this, I forked the zip4j library and modularized it:

https://github.com/jlarriba/zip4j

Download the source code, install it to your local repo and then build astounding.

I now realize that this is not very user friendly. I will close this Issue and open a new one to publish my own modularized zip4j under my own group "es.jlarriba" on central.

from jrmapi.

@jlarriba thanks - understood. What I would probably do if I were you if I had to depend on pre-Java 11 libs was to write this project in Java 11, compile it with Java 11, use Java 11 syntax (var!) but just not put a module-info.java.. unless you want to have lots of fun with JPMS, it's "not worth" the overhead of having to maintain a fork of one of the libraries you use (including keep rebasing it - see #7). Just FYI I do that in my fork in master...vorburger:vorburger (but that's not to say you should, just sharing a point of view).

from jrmapi.

@vorburger yeah, it is not bad advice. However, if no one ever starts modularizing the libraries, no modularization will be ever be possible. The lack of Java11 semantics is because I developed the library some years ago for Java8 and modularized it, as I wanted asTounding to be distributed using JPM to create thinner distributables.

The zip4j library was a choice from those days. All the rest of the libraries had already modularized versions. Instead of rebasing it, I would like to replace it with other zip java library but I have not yet found a suitable candidate.

from jrmapi.