Comments (15)
I've started a branch to split files with node. Looks promising so far.
from meteor-now.
Nice, glad to help!
from meteor-now.
No windows support yet :-(. We'll be looking into ways of supporting windows but for now this should work on any unix/linux system.
from meteor-now.
I'll re-open this ticket since we do want to have windows support. It's just going to be a bit slow since I don't have a windows machine, but I believe we can get past this error by changing https://github.com/mazlix/meteor-now/blob/master/src/dockerfile.js#L20
to const pwd = process.cwd();
However there are probably more issues that will arise on windows.
from meteor-now.
@mazlix there is ./meteor/release file containing meteor version.
from meteor-now.
:( ok thnx.
from meteor-now.
Same for me. Thanks for not supporting Windows!
var version = data.match(/METEOR@(.*)\n/)[1];
^
TypeError: Cannot read property '1' of null
from meteor-now.
Hey @gcacars, do you know the equivalent of the .meteor/release
file for windows? @purplecones and I don't have windows so it's going to be a bit of a slow process of us fixing items as reported by users like you, but basically that code seems to be failing because on windows there is no .meteor/release
file. Maybe the folder is _meteor
instead of .meteor
? If so we'd just want to add a check for OS and swap that.
from meteor-now.
@mazlix It's a normal folder:
from meteor-now.
Maybe what is different, is the meteor installation folder:
C:\Users\USER_LOGIN\AppData\Local\.meteor
or just: %UserProfile%\AppData\Local\.meteor
from meteor-now.
Same problem here on Windows. It might have something to do with the '\n' here.
When I run this in my meteor project root it always outputs null.
const fs = require('fs');
const data = fs.readFileSync('.meteor/release', {
encoding: 'utf8',
});
console.log(data.match(/METEOR@(.*)\n/));
But if I remove the '\n' or change it to '\r\n' it works.
from meteor-now.
Ah that's right! Windows uses \r\n
for line endings! I've started work on a windows support branch for these changes #29
from meteor-now.
Since I don't have a windows machine and these changes don't break mac I just merged them in and pushed an update.
If you get a chance npm install -g [email protected]
and see if it works now. At the very least you should get a new/different message 🤕
from meteor-now.
I updated it and tried running meteor-now passing two env variables. It seemed to get stuck after throwing an error on the "preparing build" step.
V [METEOR-NOW] - building meteor app
?? [METEOR-NOW] - preparing buildPossibly unhandled Error: 1 at Promise$_rejecter (C:\Users\renan.vaz\AppData\Roaming\nvm\v5.12.0\node_mo dules\meteor-now\node_modules\bluebird\js\main\promise.js:590:44) at C:\Users\renan.vaz\AppData\Roaming\nvm\v5.12.0\node_modules\meteor-now\no de_modules\promise-spawner\index.js:85:13 at tryCatch1 (C:\Users\renan.vaz\AppData\Roaming\nvm\v5.12.0\node_modules\me teor-now\node_modules\bluebird\js\main\util.js:63:19) at Promise$_callHandler [as _callHandler] (C:\Users\renan.vaz\AppData\Roamin g\nvm\v5.12.0\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:6 95:13) at Promise$_settlePromiseFromHandler [as _settlePromiseFromHandler] (C:\User s\renan.vaz\AppData\Roaming\nvm\v5.12.0\node_modules\meteor-now\node_modules\blu ebird\js\main\promise.js:711:18) at Promise$_settlePromiseAt [as _settlePromiseAt] (C:\Users\renan.vaz\AppDat a\Roaming\nvm\v5.12.0\node_modules\meteor-now\node_modules\bluebird\js\main\prom ise.js:868:14) at Promise$_settlePromises [as _settlePromises] (C:\Users\renan.vaz\AppData\ Roaming\nvm\v5.12.0\node_modules\meteor-now\node_modules\bluebird\js\main\promis e.js:1006:14) at Promise$_rejectPromises [as _rejectPromises] (C:\Users\renan.vaz\AppData\ Roaming\nvm\v5.12.0\node_modules\meteor-now\node_modules\bluebird\js\main\promis e.js:999:10) at Async$_consumeFunctionBuffer [as _consumeFunctionBuffer] (C:\Users\renan. vaz\AppData\Roaming\nvm\v5.12.0\node_modules\meteor-now\node_modules\bluebird\js \main\async.js:74:12) at Async$consumeFunctionBuffer (C:\Users\renan.vaz\AppData\Roaming\nvm\v5.12 .0\node_modules\meteor-now\node_modules\bluebird\js\main\async.js:37:14)
?? [METEOR-NOW] - preparing build
from meteor-now.
@mazlix you can get a windows 10 VirtualBox image here for testing.
I deployed a meteor app under the Windows 10 image and got this:
C:\Users\purplecones\meteor-test>meteor-now -d
[METEOR-NOW] - running command: meteor build .meteor/local/builds --server-only --architecture=os.linux.x86_64
WARNING: The output directory is under your source tree.
Your generated files may get interpreted as source code!
Consider building into a different directory instead
meteor build ../output
[METEOR-NOW] - creating Dockerfile
[METEOR-NOW] - creating supervisor
[METEOR-NOW] - splitting bundle
[METEOR-NOW] - running command: split -b 999999 .meteor/local/builds/C:\Users\purplecones\meteor-test.tar.gz .meteor/local/builds/x && rm .meteor/local/builds/C:\Users\purplecones\meteor-test.tar.gz
'split' is not recognized as an internal or external command,
operable program or batch file.
Possibly unhandled Error: 1
at Promise$_rejecter (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:590:44)
at C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\promise-spawner\index.js:85:13
at tryCatch1 (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\util.js:63:19)
at Promise$_callHandler [as _callHandler] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:695:13)
at Promise$_settlePromiseFromHandler [as _settlePromiseFromHandler] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:711:18)
at Promise$_settlePromiseAt [as _settlePromiseAt] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:868:14)
at Promise$_settlePromises [as _settlePromises] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:1006:14)
at Promise$_rejectPromises [as _rejectPromises] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\promise.js:999:10)
at Async$_consumeFunctionBuffer [as _consumeFunctionBuffer] (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\async.js:74:12)
at Async$consumeFunctionBuffer (C:\Users\purplecones\AppData\Roaming\npm\node_modules\meteor-now\node_modules\bluebird\js\main\async.js:37:14)
C:\Users\purplecones\meteor-test>^G
The problem as expected is the split
command. We might have to use something like this package and bundle it with meteor-now
since I don't believe there is an equivalent command on windows.
from meteor-now.
Related Issues (20)
- Tests are failing on Windows
- MongoDB with Meteor 1.7 fails
- Error: Slash in host identifier HOT 6
- Meteor 1.7 mongo error HOT 4
- Support for GitHub Integration
- Use multi stage Docker builds HOT 5
- ▲ The built image size (417.0M) exceeds the 100MiB limit HOT 10
- Does meteor-now support now settings in now.json or package.json? HOT 5
- Does not support standard Mongo connection string HOT 2
- just saying thanks HOT 1
- Support METEOR_PACKAGE_DIRS HOT 1
- [FAQ] Will this work with any CI? HOT 1
- Way to change code without a full re-deploy HOT 1
- first run throws error HOT 1
- Compatibility with Now 2.0? HOT 28
- Possible to deploy without rebuilding if deploy failed HOT 1
- The property `features` is not allowed in now.json HOT 9
- Alias Support not workinb HOT 1
- Project name should be taken from package.json or now.json in priority
- [Error]: `Cannot read property '1' of null` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meteor-now.