jk-labs-inc / jokerace Goto Github PK
View Code? Open in Web Editor NEWcontests for communities to run, grow, and monetize.
Home Page: https://jokerace.io
License: GNU Affero General Public License v3.0
contests for communities to run, grow, and monetize.
Home Page: https://jokerace.io
License: GNU Affero General Public License v3.0
Describe the bug
I submitted a proposal for "jokerace 29: makerdao edition," after which the proposal failed to appear among the submitted proposals and yet the "submit" button was no longer active.
To Reproduce
Expected behavior
My expectation is that a proposal that was not properly submitted with wallet approval would not render the "submit" button inactive. Rather, a fresh attempt to submit a proposal should be permitted once the Ledger is unlocked so as to approve the wallet action via MetaMask + Ledger Nano X.
Screenshots
None taken, unfortunately
Desktop (please complete the following information):
Additional context
N/A
Describe the bug
Prematurely shows Submit a proposal
To Reproduce
Steps to reproduce the behavior:
go here https://www.jokedao.io/contest/polygon/0x5165B4a0b7A49601Ec588196B5c83D04E70E58B2
Expected behavior
it should not show submit before submissions are open
Example here.
Is your feature request related to a problem? Please describe.
It can be a bit unclear to distinguish proposals from each other in contests since we just have a vertical bar distinguishing them, and each is a different size.
Describe the solution you'd like
As a temporary solution, we should try mimicking the twitter design for breaking up tweets with thin horizontal lines rather than a vertical line.
Longer-term, we should see if we can implement the original designs from figma (https://www.figma.com/file/36Qylp4x6N4pK3wXpHCj5A/jokedao-big-f'in-file?node-id=0%3A1&t=JabEWQuNN16z8Mod-1), where "voting hasn't opened" is its own window that's always centered vertically for any given proposal—showing exactly how long the proposal is without lines. Having this "voting window" be a self-contained element will be helpful later if we want to let people just type in the votes for each entry and then submit them all at the bottom of the screen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
We should think about modeling submission pop-ups after twitter with ample horizontal space to write proposals: this would reduce the rich text bar (ideally to one line) and emphasize that we can be used for serious proposals with ample features rather than just one or two line jokes.
We should also disable the pop-up disappearing when a user clicks away from it: this can leave users losing tons of valuable work with one mistake. To close it, they should have to press the x button, not click away.
And if possible, we should add in a yellow border on the pop-up like we have in the mock-ups and lose the thin white rectangular border for text. Twitter pop-ups are a good inspiration here again: they don't use any internal borders and let the user know where to type based on the blinking cursor.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is your feature request related to a problem? Please describe.
Right now the vertical sidebar and main area for text are right on top of each other. This creates dead space at the side of the screen and a feeling of tightness in the center.
Describe the solution you'd like
We can design it like notion (or even twitter): the sidebar is all the way to the left of the window (potentially in a slightly different background color), and then the main text can be in the center of the remaining space. This will give a feeling of openness, and it would be good to use the same font and size as notion as well.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Is your feature request related to a problem? Please describe.
Right now the prompts are in bold, which looks great for short prompts but makes longer prompts harder to read. the font also seems slightly smaller than the font size for the proposals, so there's a slight visual disconnect.
Describe the solution you'd like
Let's remove the bold and then play with size--let's try having the prompt be the same size as the proposals.
Describe alternatives you've considered
If we're worried that the prompt won't stand out, we can play with putting it in a box, using some color, etc... I'm glad to play with designs in figma. But let's start there.
Additional context
Add any other context or screenshots about the feature request here.
Describe the bug
If you accidentally reject a transaction in a wallet, there is no way to redeploy the transaction (on mobile, and possibly on desktop too). The transaction isn't prompted in wallet.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Submitting a transaction should deploy a transaction even if it was previously rejected
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
if you export a spreadsheet for a contest, it doesn't show the number of votes from each voter per proposal.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should be able to see the number of votes each voter gave to a proposal.
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Upon further reflection I think everything takes a while to load
Describe the bug
After using the search bar on the View Contests page once, using it again will result in a page that never loads, forcing you to hard reload the page.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The page to load the contest as usual.
Desktop (please complete the following information):
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Bug loading very long time
i had a contest where i had 1.202 token to vote, and i voted 1 out of it. on the site it shows 1 out of 0.202
which seems to deduct the voted amount from the total amount? (it would make sense to show 1 out of 1.202
instead.
Describe the bug
When I go to https://www.jokedao.io/contest/polygon/0x6E626d5e615FC930de0281e13a158E31fE8BF82b, this is what I see.
This is what I see when I spin up the site locally.
To Reproduce
Go to https://www.jokedao.io/contest/polygon/0x6E626d5e615FC930de0281e13a158E31fE8BF82b.
Expected behavior
The Contest to display.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Describe the bug
On a contest page , the webapp sometimes displays 'Application error: a client-side exception has occured`
Reloading fixes the issue.
It seemed to be linked to Infura/a RPC provider hitting a rate limit.
Screenshots
https://imgur.com/MNNEgyx
Blocked by #143
Once our tokens are burnable, we can make a token for every chain that has been minted and, in its entirety, been sent to the 0 address. We can then have an option be "submit only" when people are creating a contest where they click this button (similar to the "use my address" button) and it would populate the relevant burned token for the voting token effectively as a placeholder. This way they could run a contest that uses a valid token and noone can vote in it.
Describe the bug
lack of caching
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When pressing back, the previous info should all autofill (preferably it will not all autofill if a user is going to this page through a new flow)
Perhaps caching in browser could solve?
Most important is token address but having rest of data there to resubmit can be helpful is user hasn't submitted it
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
current text is misleading people into thinking they can use their own token (this is my fault! —david)
To Reproduce
Steps to reproduce the behavior:
*Expected behavior
change text to:
"most tokens aren't compatible with jokedao's contracts, so let's start by minting a voting token that is. skip this step only if you want to reuse a token already minted on jokedao."
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
live contests are showing most recent contests last
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should display the contests that are most current first, and contests that are latest last. Instead, it does reverse.
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Progress and definition in #113.
Describe the bug
When a link is long on mobile, it results in shrinking the remaining text so it's hard to read.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Text should take up full screen as it does for other proposals
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
on the create contest page, the button on the right said "next" rather than "skip" and a user pressed this. when she went back, it said "skip."
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Button should say "next" instead of "skip"
In addition, the "create contest" button should be in bright yellow to encourage users to tap it rather than pressing "skip"
And "skip" should be in plain text in a smaller font below "create contest" so that it's not prioritized
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
When I go to my contest page, I get a black screen with this error message on it: "application error: a client-side exception has occurred (see the browser console for more information)."
Link to contest: https://www.jokedao.io/contest/polygon/0x2bd5ec55DDA12B88F80e369b528dB58E8754D099
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the contest page to load and to see a "submit" button where I could submit proposals to the contest
Desktop (please complete the following information):
Additional context
Feel free to DM me @ddwchen on TG if you have any questions
Describe the bug
The window showing how many votes a proposal has received is using periods instead of commas (European notation instead of American), at least on mobile
To Reproduce
Steps to reproduce the behavior:
Expected behavior
All numbers should follow same American formatting, ie 15,000.01 with commas differentiating the thousands place and the period used for decimals
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Describe the bug
After I submitted a proposal to this contest, when I tried to submit again I got an ambiguous error message.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If we could tell people what the issue is here - that they have met the cap of the number of submissions they can post - I think that'd be helpful.
Desktop (please complete the following information):
Implement ERC20Burnable in our token.
Requested changes are in the figma.
Describe the bug
send button isn't turning yellow to enable rewards to be sent
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Send button should turn yellow
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
"Submissions Open" shows as "Voting Opens" before contests start
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should read "Submissions open in" instead of "Voting opens in"
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
When connected to Polygon, this contest (on Goerli) https://www.jokedao.io/contest/goerli/0x71AFb5cD5785825568f9f8ACccd2b00f9aE7A29F loads the contest info after a couple of error messages.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When the user is connected to the wrong chain we want to prompt them to change chains.
Another example with a live contest (here):
Desktop (please complete the following information):
Additional context
I think this has to do with our loading some things if the user is connected and some regardless of if they are - I think we just need to really align these checks and also ensure that in all cases if the user is connected but on the wrong network we always prompt them to switch even if we can load the data.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
no
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
Started on this branch.
Describe the bug
contests say "used points" instead of "remaining points"
To Reproduce
Steps to reproduce the behavior:
Expected behavior
it should say "your remaining points" after a contest (and ideally "your available points" during a contest)
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
When opening a URL to a specific contest, while already connected via MetaMask to an incorrect network, the UI informs user via a persistent on-screen notification that "something went wrong while fetching this contest." A temporary banner notification, meanwhile, informs the user that "this contract doesn't exist on this chain."
There is no other feedback to the user identifying the correct chain, even when using the on-site network picker. A user who is not already aware of what the correct network is for the contest would have to seek out that information elsewhere or attempt to discover it through trial and error.
To Reproduce
Expected behavior
I expect a notification prompting a switch to the specific network on which the contest resides.
Desktop (please complete the following information):
Describe the bug
Couldn’t get to push submit button on proposal problems with layout
Steps to reproduce the behavior:
Expected behavior
Would love to submit proposal on smartphone
Smartphone (please complete the following information):
Describe the bug
Users are prompted to switch contests even though they can view the contest on their current chain
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Users should be prompted to switch networks if they need to use their wallet, ie for submitting or voting
But there is another smaller issue too: the contest is still loading when they are prompted to change networks, so they don't know that they could stay on the page. It looks like they need to switch networks to view the contest (though this is not the case). If we want to consider a smaller change, we could wait to show the "switch network" prompt until the contest loads, and change the language to reflect that to participate they need to change (but they can still view the contest on their current chain).
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
[Android Chrome browser, metamask mobile wallet]
Describe the bug
A clear and concise description of what the bug is.
UI showed 1 vote but actual amount was 0.999999
This made it looks like I could not vote when entering the '1' that the UI said I had available to vote.
To Reproduce
Steps to reproduce the behavior:
Not sure how to recreate this.
Expected behavior
A clear and concise description of what you expected to happen.
Expected that when the UI says I have 1 vote left that I can enter '1' and vote.
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
Every proposal has regular text surrounded by quotes
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Proposals shouldn't have quotes
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
integrations (just user entering metadata) vs modules (if the creator needs to do things)
WETH is showing on this rewards module for example even though it has never been sent to the module.
Describe the bug
error message pressing skip on create contests
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Should not show error but instead go to airdrop page
If it does show error, this should be explained
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
I can't replicate this one but saw a user experience it when the button said "skip" instead of "next"
Is your feature request related to a problem? Please describe.
Sometimes the website has a pretty long loading time, for example when opening the Contest Info page.
Describe the solution you'd like
Instead of merely displaying a rotating card loading animation, we can include random humorous facts about Jokedao to make it both entertaining and informative. As an example, we can take inspiration from the Discord loading screen with its "Did you know" feature. This will only be implemented on the Contest Info Page, without impacting any other pages, and can be easily activated by using the "withFunFact" props in the Loader component.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
The fun facts will be based on jokedao faq
examples:
Describe the bug
when anyone can submit, we're still showing that there's a submission token on the rules page
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Under submission token should say "no submission token for this contest"
Screenshots
If applicable, add screenshots or a video (checkout Loom) to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
Describe the bug
After creating a contest on Polygon Mumbai network, it's impossible to display their contest page
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The contest data should be displayed
** Potential fix **
This is probably due to the way we handle the chain
parameter value in /[chain]/[contest]
.
Indeed, currently we simply toLowerCase()
the network name, which doesn't translate nicely in url parameters if the name has space in it.
2 possible solutions :
encodeURI()
and decodeURI()
(https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Global_Objects/encodeURI)replace('" ", "")
(probably the easiest)A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.