Code Monkey home page Code Monkey logo

Comments (22)

damencho avatar damencho commented on June 12, 2024

Which version of electron is that?
It is normal to drop the video to 360 when you show the meeting in tileview. If you switch to stage view, only the stage participant will be requested with HD and the rest with 180p.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Which version of electron is that? It is normal to drop the video to 360 when you show the meeting in tileview. If you switch to stage view, only the stage participant will be requested with HD and the rest with 180p.

Electron 22, but I tested it even on Electron 27, and happened too. The video shared makes it unreadable when the Electron window enters the call. There is any limitations on the version known for this?

from jitsi-meet.

jallamsetty1 avatar jallamsetty1 commented on June 12, 2024

Can you check what is the tile height thats calculated on the electron client? The log should look something like this

2024-02-22T18:02:43.997Z [features/video-quality] <sF.register.deepEquals [as listener]>: Video quality level for thumbnail height: 587.5, is: 360, override: false, max full res N: 2

For example, in this case, the height of each of the tiles is 587.5 pixels, so the client is going to request the bridge to send 360p videos.

Only if the calculated height >= 720, the client will request 720p videos from the bridge as seen in the below log.

2024-02-22T18:04:57.845Z [features/video-quality] <sF.register.deepEquals [as listener]>: Video quality level for thumbnail height: 1078.1333333333334, is: 720, override: false, max full res N: 2

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

We have the same problem on our site. How can I check this in the electron client ?

from jitsi-meet.

saghul avatar saghul commented on June 12, 2024

You can enable developer tools and check in the console tab.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Sorry for the late reply, I got sick last week.
The size doesnt seem to deteriorate, I tried opening on big window sizes and seems to do the same thing.
The unique thing that I could see is that when there are more than two users the call changes to conference and stop using p2p and start using a url that shows on the console.
I tried opening more clients on safari and Firefox along and seems to be deteriorating too. So I dont know if there is any limitation on quality for conference?
I need help to understand what could do the screen sharing video decrease it quality and how this can be handled on this cases.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Can you check what is the tile height thats calculated on the electron client? The log should look something like this

2024-02-22T18:02:43.997Z [features/video-quality] <sF.register.deepEquals [as listener]>: Video quality level for thumbnail height: 587.5, is: 360, override: false, max full res N: 2

For example, in this case, the height of each of the tiles is 587.5 pixels, so the client is going to request the bridge to send 360p videos.

Only if the calculated height >= 720, the client will request 720p videos from the bridge as seen in the below log.

2024-02-22T18:04:57.845Z [features/video-quality] <sF.register.deepEquals [as listener]>: Video quality level for thumbnail height: 1078.1333333333334, is: 720, override: false, max full res N: 2

This will show on the console as the new users enter the call?

from jitsi-meet.

saghul avatar saghul commented on June 12, 2024

It will show up with layout changes.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

It will show up with layout changes.

There isnt any log with video-quality nor nothing that is on the line of example. So dont seem to be this the change.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Chrome Screen sharer console log:
chrome screen sharer.log

Chrome viewer console log:
chrome viewer.log
quality:
SCR-20240305-mkwb

Electron viewer console log:
electron viewer.log

quality after electron client enter the call:
SCR-20240305-mlqr

from jitsi-meet.

saghul avatar saghul commented on June 12, 2024

Did you make window size changes, for example?

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

We did the following change from:
disableSimulcast: false,
to:
disableSimulcast: true,
And now we can use the application window again.
But I don't think this is a proper solution ?

from jitsi-meet.

saghul avatar saghul commented on June 12, 2024

Not it isn't. How big is your window and are you resizing it at runtime?

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

We are always working in fullscreen mode. The application window is I think around 800x600 at the beginning. That is the standard size. And we normally resize it to fullscreen.

from jitsi-meet.

saghul avatar saghul commented on June 12, 2024

Then you should see the messages @jallamsetty1 mentioned in the console logs.

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

Perhaps @jeanfbrito can test this. He is the developer at RocketChat.

from jitsi-meet.

jallamsetty1 avatar jallamsetty1 commented on June 12, 2024

Chrome Screen sharer console log:
chrome screen sharer.log

Can you please share the full log from the screen sharer? I see the logs only upto the moment when the electron client joined and nothing after so it is hard to tell if having the electron client in the call changed the sender characteristics. Please share the full log for both the sender and the electron clien.

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

I cannot open the developer tools (CTRL SHIFT I or F12) in the application window. Please tell me how to do this easily. It doesn't make sense to do this in the browser, because the problem doesn't appear there.

from jitsi-meet.

jallamsetty1 avatar jallamsetty1 commented on June 12, 2024

Are you saying that you are seeing the share blurry only on the electron client? If everyone in the call is seeing the share blurry as soon as the electron client joins the call then the problem should be on the sender.

from jitsi-meet.

moell9 avatar moell9 commented on June 12, 2024

Yes. Not only is the sharing blurred, but also the participants are all displayed with too low a resolution. Mostly in 180p.
With disableSimulcast: true, the resolution is fine, up to 720p and also the sharing.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Did you make window size changes, for example?

No because I was using fullscreen windows for testing, something near 1440p height.

from jitsi-meet.

jeanfbrito avatar jeanfbrito commented on June 12, 2024

Chrome Screen sharer console log:
chrome screen sharer.log

Can you please share the full log from the screen sharer? I see the logs only upto the moment when the electron client joined and nothing after so it is hard to tell if having the electron client in the call changed the sender characteristics. Please share the full log for both the sender and the electron clien.

It was my intention, let me do again, maybe I cleaned up before entering with other clients.

from jitsi-meet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.