Change from JS to native Google Calendar Template system to fix bug? about jidesha HOT 5 OPEN

Thanks, if you have it handy you can push a PR, thanks.

from jidesha.

Yes no problem - it'll probably be over the weekend

from jidesha.

Submitted for review @damencho - let me know if you want any changes or feel free to modify.

from jidesha.

What is the state of this PR?

• in popup.js build vars and replace placeholders
  Unfortunately since I don't think Outlook has an equivalent we still need the extid system, but only for OWA. So either popup.js switches depending on URL or '&extid=' + chrome.runtime.id get's injected in popup.html instead.

Is this implemented?

Thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would, unfortunately, be unable to merge your patch unless we have that piece :(.

from jidesha.

I've signed the ICLA

Looking at the commit it looks like it's missing the &extid=' + chrome.runtime.id for Outlook part, I imagine I was waiting for input on which way to solve it.

I may be able to come back to this but current commitments and the fact I don't run it the extension currently means it may take a while

from jidesha.