Comments (11)
Hi,
I also ran into this problem:
When the conference duration limit is exceeded, jicofo removes it from the conference map but when someone tries to start this terminated conference again, no request is sent to reservation system and the conference starts without reservation system being informed!
I had an ambiguity about expected behavior of reservation system:
Why Jicofo destroys XMPP MUC room only when duration limit is exceeded and not when everyone leaves the conference?
Does the reservation system should delete its record from its database immediately after receiving DELETE request from jicofo, or wait until its duration limit is exceeded and then delete the related record?
Any further works on this problem is appreciated :)
from jicofo.
Nice catch ! Thanks for looking into this. I was planning to get rid of FocusAllocationListener in favour of "focus created" and "focus destroyed" events:
https://github.com/jitsi/jicofo/blob/master/src/main/java/org/jitsi/jicofo/FocusManager.java#L325
https://github.com/jitsi/jicofo/blob/master/src/main/java/org/jitsi/jicofo/FocusManager.java#L396
Unfortunately we're not using that code, so it may take a lot of time before that happens, but we would appreciate a PR that does that !
from jicofo.
Hi ! Thanks for the report ! Not sure when we'll have the time to fix the issue, but PR fixing it would be welcome !
from jicofo.
Actually it should be called from here as well:
https://github.com/jitsi/jicofo/blob/master/src/main/java/org/jitsi/jicofo/FocusManager.java#L368
from jicofo.
Are you sure? Because the ConferenceExpireTask
class of RESTReservations
already calls focusManager.destroyConference()
which then in turn would call RESTReservation.destroyConference()
again. Seems a bit kludgy to me? Isn't is possible to hook it up somewhere in the FocusComponent
, which already does the createConference()
call and has a reference to the reservation system?
from jicofo.
I've been digging through the code, but I see that the reservation system does a focusManager.setFocusAllocationListener(this)
when started. The onFocusDestroyed
method on the reservation system thus already should handle conference destruction and deregistration. However, it seems that the AbstractAuthAuthority
, and thus the XMPPDomainAuthAuthority
that we are using, also does a focusManager.setFocusAllocationListener(this)
! Aren't these calls overwriting each other's listening objects?
from jicofo.
i am also running into this issue.
Thre behaviour is that the conference is not removed from the HashMap in the REST part of the code, and thus, when the room should be recreated, the reservation system is not queried
see RESTReservations.java#L207
from jicofo.
Hi,
I'm having the same behaviour, it is unexpected to be able to join a deleted conference.
I'm expecting the DELETE request to "delete" the conference. Any attempt to access it again should IMO result in another post request.
from jicofo.
I'm not looking on any of those issues and have no plans to do so in the near future. If you have a problem the fastest way would be to submit a patch.
from jicofo.
@NeoN0x I'm planning to look into this in the near future: jitsi/jitsi-meet#8386
And merge it and when that is done we will deprecate the one in jicofo and will drop it at some point. So you better try that one, if you see problems with it we can fix them ...
from jicofo.
Reservations are moved to a prosody module
from jicofo.
Related Issues (20)
- Whole bridge terminates upon Unknown endpoint jvb error HOT 6
- Conference is not moved to another jvb when JVB's XMPP connection is broken HOT 1
- Not applayed some parametrs from jicofo.conf HOT 4
- Failed to start jicofo HOT 2
- Can't find certificate HOT 1
- Temporarily failing bridge healthcheck permanently leaves Jitsi without any operational bridges HOT 6
- Jicofo does not recover after oom-kill HOT 3
- jicofo fails to start, uncaught exception HOT 3
- Failed to grant owner status: Bare JID expected, got full JID HOT 8
- Room remains open after destroy HOT 4
- Jicofo reinvite Jigasi transcriber on failure HOT 7
- Question about potential issue with Colibr2's transport update HOT 2
- Bridge stress level unaffected by RecentlyAddedEndpoints, participants assigned to single videobridge HOT 1
- Something wrong in new installation with secure domain , few Important changes are not clear/updated in documentation HOT 1
- java.lang.NullPointerException HOT 1
- Race condition on startup leads to NPEs and failed requests HOT 2
- jicofo 1.0-934-1 installs garbage into /etc/logrotate.d/ HOT 1
- Debian dpkg throws warnings trying to delete /etc/logrotate.d/jicofo HOT 2
- The participant counter will not updated when a meeting has ended HOT 1
- Jicofo stats do not clean up after update to jicofo 1.0-940-1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jicofo.