Add a preference for 'git' location. about gitgutter HOT 12 CLOSED

@sorahn Thanks for reporting. If you make a pull request that does this I will accept it. It shouldn't be very hard, just make it fall back to what it currently is now if not set in preferences. For an example of how to make a preference fall back look here I am falling back to true if live mode is not set.

from gitgutter.

@jisaacks I don't know anything about Python, but I''ll see what I can do!

from gitgutter.

@sorahn give it a try, you may like Python. If you have trouble just do a pull request so I can see what you have and let me know what you are having trouble with and I will be glad to help out. Or if that doesn't sound interesting to you, that's cool too; I can work on it. :)

from gitgutter.

Well I didn't mean to open a new issue. Sorry about that!

from gitgutter.

@sorahn when you create a pull request it automatically creates a new issue. It's just part of the process, so don't worry about it. Your code looks solid, does it fix it for your git installation? can you also show an example of what your preferences looks like to set the git path. I may want to add that to the read me so other people can benefit from it as well. Thanks.

from gitgutter.

I thought you could attach code to existing issues. Anyway, my preference looks like this.

{
  "git_gutter_git_command": "/usr/local/bin/git"
}

I tested this by having the update command run print out which git to verify that when I changed the preference, the output changed.

from gitgutter.

I thought you could attach code to existing issues.

Not that I am aware of.

I will test this tomorrow on my machine (I'm on my phone right now) and merge it in. 👍

from gitgutter.

@sorahn I got on my wife's macbook and installed git via homebrew so I could test this. Funny thing is, it installed git here: /usr/bin/git as well as /usr/local/bin/git which is a symlink to /usr/local/Cellar/git/1.7.11.1/bin/git

When I run which git it lists the one at /usr/bin/git and it worked with GitGutter in Sublime without needing to specify the path.

So I am curious why your installation of git via brew did not put one in /usr/bin/git. I wonder, can you try copying your symlink at /usr/local/bin/git to /usr/bin/git and see if that fixes the issue. If so, that may be a better fix, and I would rather not add more complexity to the GitGutter codebase if I don't need to. If that works, as a bonus, it should also work for your other git plugin that you said could not find git.

Try it and let me know.

from gitgutter.

That's actually something I noticed when I got home to make this change. My work machine did not have /usr/bin/git and my solution was to symlink /usr/local/bin/git (which, like yours was itself a symlink to the one in Cellar) to /usr/bin/git.

Maybe i'm worse off not having git in /usr/bin, but its easy enough to add the ability to run any version of git on the system.

from gitgutter.

@sorahn so if i understood you correctly it sounds like the symlink is the better solution and this pull request is no longer needed. Do you agree?

from gitgutter.

Well, I guess I maybe still see some value in offering people the option to override the default version of git if they want. It's up to you. My specific issue can be resolved with out this pull request though.

from gitgutter.

Alright I merged it in. Sorry it took so long, I got struck with a pretty bad flu.

This is is not fixed by 5eed766

from gitgutter.