Changed lines icons are … borked? about gitgutter HOT 9 CLOSED

ah, progress: The issue seems to be caused by the following in my theme file:

        <dict>
            <key>name</key>
            <string>diff.header</string>
            <key>scope</key>
            <string>meta.diff</string>
            <key>settings</key>
            <dict>
                <key>foreground</key>
                <string>#333333</string>
                <key>background</key>
                <string>#aaaaaa</string>
            </dict>
        </dict>

from gitgutter.

@joeybaker is this issue resolved?

from gitgutter.

I'd say not. The workaround is to remove the setting above, but that is an unfortunate "fix" because the above setting does help style actual diff files. It would be great if GitGutter could DoTheRightThing™ when that setting is present.

from gitgutter.

@joeybaker hmm, I will put an entry like that into my color scheme and see if it borks it up for me as well, and see what I can figure out.

from gitgutter.

Not sure if this helps but I had to disable a bit more than the previous example

<dict>
    <key>name</key>
    <string>diff.header</string>
    <key>scope</key>
    <string>meta.diff, meta.diff.header</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#75715E</string>
    </dict>
</dict>
<dict>
    <key>name</key>
    <string>diff.deleted</string>
    <key>scope</key>
    <string>markup.deleted</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#00A8C6</string>
    </dict>
</dict>
<dict>
    <key>name</key>
    <string>diff.inserted</string>
    <key>scope</key>
    <string>markup.inserted</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#A6E22E</string>
    </dict>
</dict>
<dict>
    <key>name</key>
    <string>diff.changed</string>
    <key>scope</key>
    <string>markup.changed</string>
    <key>settings</key>
    <dict>
        <key>foreground</key>
        <string>#E6DB74</string>
    </dict>
</dict>

For now I'm just commenting it out for my main theme. Not sure how you would bypass it on your end.

from gitgutter.

I get this too

from gitgutter.

@stephenway your settings look exactly like mine (with just one of the color values different) and mine works fine.
@joeybaker I swapped my settings with your example, mine still worked fine.

Can you guys confirm that your installation of "GitGutter" in installed a directory named GitGutter and not Git Gutter. There was an issue before with the icons not working because the file path was incorrect.

Also when you fire up Sublime and get the borked looking icon type ctrl+` to open a console and look for an error coming from git_gutter.py

from gitgutter.

I was having this issue as well. I commented out the lines in question, and then it worked fine. Strangely though, when I un-commented them, it continued to work fine. Not sure what the deal is, but it appears to be permanently fixed for me.

from gitgutter.

@jisaacks the package is installed to GitGutter and there are no console messages

Strangely, I followed @lankybutmacho's advice all is now well! uncommenting the lines (though I swear I did this before) leaves the correct behavior intact. Restarting ST2 doesn't make the problem re-appear, so short of marking Dec 13th off as a bad day, I'm now a happy camper, and can't reproduce the problem!

from gitgutter.